From 41c53ec0e2b0b6ef8e3523b85307a3de3d614ac6 Mon Sep 17 00:00:00 2001
From: Harshal Patil <12152047+harche@users.noreply.github.com>
Date: Fri, 19 Jun 2026 11:13:23 -0400
Subject: [PATCH] evals: resync analysis schema with operator (#174)

ANALYSIS_WITH_COMPONENTS_SCHEMA mirrors the operator's AnalysisOutputSchema.
Sync it with the operator change in
openshift/lightspeed-agentic-operator#174:

- drop estimatedImpact (removed from the operator API and CRD)
- require name+type on verification.steps[] items and description on the
  verification object, matching the operator schema / AnalysisResult CRD

Verified by the live claude/Vertex eval (test_find_token_skill) and offline
jsonschema checks. Pre-existing eval-specific divergences (token sentinels,
lowercase enums, boolean reversible) are intentional and left unchanged.
---
 evals/schemas.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/evals/schemas.py b/evals/schemas.py
index d390b1a..d1c50f8 100644
--- a/evals/schemas.py
+++ b/evals/schemas.py
@@ -50,7 +50,6 @@
                                 "enum": ["low", "medium", "high", "critical"],
                             },
                             "reversible": {"type": "boolean"},
-                            "estimatedImpact": {"type": "string"},
                         },
                         "required": ["description", "actions", "risk", "reversible"],
                     },
@@ -69,6 +68,7 @@
                                         "expected": {"type": "string"},
                                         "type": {"type": "string"},
                                     },
+                                    "required": ["name", "type"],
                                 },
                             },
                             "rollbackPlan": {
@@ -79,6 +79,7 @@
                                 },
                             },
                         },
+                        "required": ["description"],
                     },
                     "rbac": {
                         "type": "object",