Skip to content

luci-app-crowdsec-firewall-bouncer: rename UCI config file to crowdsec-firewall-bouncer#8691

Open
dwardor wants to merge 1 commit into
openwrt:masterfrom
dwardor:crowdsec
Open

luci-app-crowdsec-firewall-bouncer: rename UCI config file to crowdsec-firewall-bouncer#8691
dwardor wants to merge 1 commit into
openwrt:masterfrom
dwardor:crowdsec

Conversation

@dwardor

@dwardor dwardor commented Jun 7, 2026

Copy link
Copy Markdown

Pull request details

Description

The UCI config file for crowdsec-firewall-bouncer is being renamed from crowdsec to crowdsec-firewall-bouncer to avoid a file ownership conflict with the crowdsec package
It depends on openwrt/packages#29666 to fix openwrt/packages#28615
It updates form.js and the rpcd ACL file accordingly.

This is based on leow140's original PRs (#8472 and openwrt/packages#8991) which went stale and were closed

Screenshot or video of changes (if applicable)

Maintainer (preferred)

@systemcrash


Tested on

OpenWrt version: OpenWrt 25.12.4
LuCI version: LuCI openwrt-25.12 branch
Web browser(s): Vivaldi 8.0.4033.34


Checklist

  • This PR is not from my main or master branch 💩, but a separate branch. ✅
  • Each commit has a valid ✒️ Signed-off-by: <my@email.address> row (via git commit --signoff).
  • Each commit and PR title has a valid 📝 <package name>: title first line subject for packages.
  • Incremented 🆙 any PKG_VERSION in the Makefile.
  • (Optional) Includes what Issue it closes (e.g. openwrt/luci#issue-number).
  • (Optional) Includes what it depends on (e.g. openwrt/packages#pr-number in sister repo).

@github-actions

This comment has been minimized.

@dwardor dwardor force-pushed the crowdsec branch 2 times, most recently from 5628ada to 61a8095 Compare June 7, 2026 15:18
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. The config rename in form.js and the rpcd ACL file is consistent: the form.Map name and both uci ACL entries move from crowdsec to crowdsec-firewall-bouncer, the TypedSection type bouncer is correctly left unchanged, and menu.d references the ACL group (not the config name) so it needs no change.

This is frontend-only until the backend rename lands: the crowdsec-firewall-bouncer package on packages master still installs its config as /etc/config/crowdsec and does config_load "crowdsec", so the new name only resolves once the depended-on openwrt/packages#29666 renames it. That dependency is disclosed in the PR body, so this is context, not a blocker.

One inline nit on an out-of-scope UI label change.


Generated by Claude Code

The UCI config file for crowdsec-firewall-bouncer is being renamed from
`crowdsec` to `crowdsec-firewall-bouncer` to avoid a file ownership
conflict with the crowdsec package (openwrt/packages#29666 to fix
openwrt/packages#28615).
Updates form.js and the rpcd ACL file accordingly.

This is based on leow140's original PRs (openwrt#8472 and
openwrt/packages#8991) which went stale and were closed

Signed-off-by: Benjamin Réveillé <benjamin.reveille@gmail.com>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit; no new issues found.

The previously-flagged out-of-scope UI label change has been dropped — the section title is back to _('Bouncer'), so the diff is now confined to the form.Map config name and the two rpcd ACL uci entries (crowdseccrowdsec-firewall-bouncer). The TypedSection type 'bouncer' is correctly left unchanged. The shortened commit subject ("rename UCI config file") now matches the actual change and resolves the formality subject-length error.

As before, this is frontend-only until the backend rename lands: on packages master the crowdsec-firewall-bouncer package still installs /etc/config/crowdsec and the init script uses CONFIGURATION=crowdsec / procd_add_config_trigger "config.change" "crowdsec", so the new name only resolves once the depended-on openwrt/packages#29666 renames it. That dependency is disclosed in the PR body, so this is context, not a blocker.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crowdsec-firewall-bouncer: Installing fails as it tries to overwrite etc/config/crowdsec owned by crowdsec

2 participants