exfatprogs: add test-version.sh#29423
Closed
commodo wants to merge 1 commit into
Closed
Conversation
Add test-version.sh: fsck.exfat and mkfs.exfat both print the version string via show_version() but exit non-zero when invoked with -V (fsck exits with FSCK_EXIT_SYNTAX_ERROR, mkfs exits with EXIT_FAILURE). The CI generic version checker uses '|| continue' to skip failed commands, so it never sees the printed version and reports "No executables in the package provided version X.Y.Z". test-version.sh captures the output regardless of exit code and greps for the expected version string, fixing the generic test failure. Signed-off-by: Alexandru Ardelean <alex@shruggie.ro>
Member
|
I don't think this should be addressed for each package indivually. |
Contributor
Author
|
Fine by me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @dangowrt
Description:
Add test-version.sh: fsck.exfat and mkfs.exfat both print the version string via show_version() but exit non-zero when invoked with -V (fsck exits with FSCK_EXIT_SYNTAX_ERROR, mkfs exits with EXIT_FAILURE). The CI generic version checker uses '|| continue' to skip failed commands, so it never sees the printed version and reports "No executables in the package provided version X.Y.Z".
test-version.sh captures the output regardless of exit code and greps for the expected version string, fixing the generic test failure.
🧪 Run Testing Details
✅ Formalities