ocserv: support custom server SSL certificate#29604
Open
jacklovell wants to merge 1 commit into
Open
Conversation
Add UCI options for the path to the server's SSL certificate and private key. This enables the use of a certificate provided by an external certificate authority instead of the default self-signed certificate. The self-signed certificate is still produced if it doesn't already exist, and is used by default. So this change should be transparent to existing users. Fixes openwrt#23099. Signed-off-by: Jack Lovell <jacklovell1990@gmail.com>
Author
|
I guess luci-app-ocserv should also be updated to support the new UCI options if this gets merged, but would it be better to do that in a separate PR or add the changes to this one? |
Contributor
|
Shouldn't this go to master first and then to branch? Regarding luci, I'd keep these separate as a second step. |
Author
I don't know, this is my first time contributing to OpenWRT packages. I haven't tested it against snapshot, only 25.12. Though I have no reason to expect it wouldn't work on master. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add UCI options for the path to the server's SSL certificate and private key. This enables the use of a certificate provided by an external certificate authority instead of the default self-signed certificate.
The self-signed certificate is still produced if it doesn't already exist, and is used by default. So this change should be transparent to existing users.
Fixes #23099.
📦 Package Details
Maintainer: @nmav
Description:
Add UCI options for the path to the server's SSL certificate and private key. This enables the use of a certificate provided by an external certificate authority instead of the default self-signed certificate.
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.