nut: rewrite scripts#29607
Draft
danielfdickinson wants to merge 7 commits into
Draft
Conversation
danielfdickinson
force-pushed
the
pr-nut-refactor-and-bump-version
branch
2 times, most recently
from
5c57d79 to
f4e379f
Compare
danielfdickinson
force-pushed
the
pr-nut-refactor-and-bump-version
branch
2 times, most recently
from
ac7f53a to
68f6d99
Compare
Member
|
It looks like Copilot does not like me. 😭😭 |
Contributor
Author
|
A few things to fix, a couple of which are more about 'in case some targets behave differently' than actively incorrect (and were tested on a Pi 2, with no issues). Better than I feared, with the size of the changeset. |
Bump version to latest stable release. Adjust configure and drivers as needed. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
They are executables not libraries, so move the UPS drivers to /usr/libexec/nut. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
For files with an existing OpenWrt copyright notation, update to include 2026 for scripts which have been updated this year. Per openwrt#29390 (comment) Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Allow CI to pass by skipping the generic version check where it not appropriate. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Add previously missed migration script (uci-defaults) for changes to nut-monitor initscript. Created with the help of iterative code reviews by Qwen3.6-27B (LLM model) running on llama.cpp (local LLM server), controlled by LATE. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
Extra quotes were being interpreted literally, preventing proper ups driver stop and/or reload. Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
The scripts were a mess. Attempting even a simple update caused many Copilot complaints. So we rewrite the scripts to be cleaner and resolve the issues found by automated code review (such as Copilot). Made extensive use of Qwen3.6-27B, LATE, and llama.ccp for local AI code reviews during development. In the process we deduplicate the nut-server and nut-monitor initscripts and split them into several files, for easier automatic and human review. Incorporates and supersedes: openwrt#28308 Should supersede openwrt#21014 Closes: openwrt#28298 Signed-off-by: Daniel F. Dickinson <dfdpublic@wildtechgarden.ca>
danielfdickinson
force-pushed
the
pr-nut-refactor-and-bump-version
branch
from
68f6d99 to
e761068
Compare
Contributor
Author
You sure it not me it doesn't like? It seems do this a lot with my PRs... |
Contributor
Author
|
Interesting. CI failure due to not being able to pull the test container from the registry. I'm guessing that should be a transient failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @@danielfdickinson
Also notify: @rpavlik @systemcrash @BKPepe
Description:
Note: Will need to be rebased once #29592 is merged. #29592 has
all but the last commit (rewrite scripts).
The scripts were a mess. Attempting even a simple update caused many
Copilot complaints. So we rewrite the scripts to be cleaner and
resolve the issues found by automated code review (such as Copilot).
Made extensive use of Qwen3.6-27B, LATE, and llama.cpp for local AI
code reviews during development.
In the process we deduplicate the nut-server and nut-monitor
initscripts and split them into several files, for easier automatic
and human review.
Incorporates and supersedes: #28308
Should supersede #21014
Closes: #28298
🧪 Run Testing Details
To be done (hence draft)
Also need to develop a robust test plan, given the scope of the changes.
'smoke test' only (more comprehensive testing required)
✅ Formalities