[WIP]: smartdns: update to version 48.1#29665
Open
pymumu wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the SmartDNS OpenWrt package to a newer upstream release and introduces an optional smartdns-ui package that builds/installs a Rust-based plugin plus web UI assets.
Changes:
- Bump
smartdnsfrom 46.1 to 48.1 (source URL + hash updated). - Add
smartdns-uisubpackage with Rust host tooling integration and web UI download/build steps. - Adjust packaging metadata by factoring common package fields into
Package/smartdns/defaultand addinglibatomicdependency.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pymumu
force-pushed
the
master
branch
5 times, most recently
from
a5c53a3 to
1ebea16
Compare
Comment on lines
+12
to
+15
| PKG_SOURCE_PROTO:=git | ||
| PKG_SOURCE_URL:=https://www.github.com/pymumu/smartdns.git | ||
| PKG_SOURCE_VERSION:=64fc9f20fba0e14cb118fe7f145557971cafd858 | ||
| PKG_MIRROR_HASH:=skip |
Comment on lines
+100
to
+104
| define Build/Compile/smartdns-webui | ||
| which npm || (echo "npm not found, please install npm first" && exit 1) | ||
| npm install --prefix $(PKG_BUILD_DIR)/smartdns-webui/ | ||
| npm run build --prefix $(PKG_BUILD_DIR)/smartdns-webui/ | ||
| endef |
Comment on lines
+123
to
+126
| define Build/Prepare | ||
| $(call Build/Prepare/Default) | ||
| $(TAR) -C $(PKG_BUILD_DIR)/ -xf $(DL_DIR)/$(SMARTDNS_WEBUI_FILE) | ||
| endef |
Comment on lines
+100
to
+104
| define Build/Compile/smartdns-webui | ||
| which npm || (echo "npm not found, please install npm first" && exit 1) | ||
| npm install --prefix $(PKG_BUILD_DIR)/smartdns-webui/ | ||
| npm run build --prefix $(PKG_BUILD_DIR)/smartdns-webui/ | ||
| endef |
Comment on lines
+88
to
+90
| define Package/smartdns-ui/conffiles | ||
| /etc/config/smartdns | ||
| endef |
Comment on lines
+111
to
+121
| define Download/smartdns-webui | ||
| FILE:=$(SMARTDNS_WEBUI_FILE) | ||
| PROTO:=$(SMARTDNS_WEBUI_SOURCE_PROTO) | ||
| URL:=$(SMARTDNS_WEBUI_SOURCE_URL) | ||
| MIRROR_HASH:=$(SMARTDNS_WEBUI_HASH) | ||
| VERSION:=$(SMARTDNS_WEBUI_SOURCE_VERSION) | ||
| HASH:=$(SMARTDNS_WEBUI_HASH) | ||
| SUBDIR:=smartdns-webui | ||
| endef | ||
| $(eval $(call Download,smartdns-webui)) | ||
|
|
Signed-off-by: Nick Peng <pymumu@gmail.com>
Comment on lines
+96
to
+99
| define Build/Compile/smartdns-webui | ||
| $(STAGING_DIR_HOSTPKG)/bin/npm ci --prefix $(SMARTDNS_WEBUI_BUILD_DIR) --no-audit --no-fund | ||
| $(STAGING_DIR_HOSTPKG)/bin/npm run build --prefix $(SMARTDNS_WEBUI_BUILD_DIR) | ||
| endef |
Comment on lines
+31
to
34
| PKG_BUILD_DEPENDS:=PACKAGE_smartdns-ui:rust/host PACKAGE_smartdns-ui:node/host | ||
|
|
||
| include ../../lang/rust/rust-package.mk | ||
| include $(INCLUDE_DIR)/package.mk |
Comment on lines
25
to
27
| PKG_MAINTAINER:=Nick Peng <pymumu@gmail.com> | ||
| PKG_LICENSE:=GPL-3.0-or-later | ||
| PKG_LICENSE_FILES:=LICENSE |
Comment on lines
+125
to
+131
| define Build/Compile | ||
| $(call Build/Compile/Default,smartdns) | ||
| ifdef CONFIG_PACKAGE_smartdns-ui | ||
| $(call Build/Compile/smartdns-ui) | ||
| $(call Build/Compile/smartdns-webui) | ||
| endif | ||
| endef |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @pymumu
Description: upgrade smartdns to version 48.1
🧪 Run Testing Details
✅ Formalities