fix: invoke ConfigurationServiceOverrider consumer only once in Operator constructor (#3353)

Signed-off-by: Dennis-Mircea Ciupitu <dennis.mircea.ciupitu@gmail.com>

Author: Dennis-Mircea

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/Operator.java

@@ -122,21 +122,10 @@ private void init(ConfigurationService configurationService, boolean allowDeferr
    */
   protected ConfigurationService initConfigurationService(
       KubernetesClient client, Consumer<ConfigurationServiceOverrider> overrider) {
-    // initialize the client if the user didn't provide one
-    if (client == null) {
-      var configurationService = ConfigurationService.newOverriddenConfigurationService(overrider);
-      client = configurationService.getKubernetesClient();
+    if (client != null) {
+      Consumer<ConfigurationServiceOverrider> bindClient = o -> o.withKubernetesClient(client);
+      overrider = overrider == null ? bindClient : overrider.andThen(bindClient);
     }
-
-    final var kubernetesClient = client;
-
-    // override the configuration service to use the same client
-    if (overrider != null) {
-      overrider = overrider.andThen(o -> o.withKubernetesClient(kubernetesClient));
-    } else {
-      overrider = o -> o.withKubernetesClient(kubernetesClient);
-    }
-
     return ConfigurationService.newOverriddenConfigurationService(overrider);
   }