improve: deprecated isWatching method for informers health indicator

This method is not suitable as a health indicator

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/health/InformerHealthIndicator.java

@@ -19,6 +19,12 @@ public interface InformerHealthIndicator extends EventSourceHealthIndicator {
 
   boolean hasSynced();
 
+  /**
+   * @deprecated this method is not suitable for health check, it is expected
+   * that the watches sometimes fail.
+   * @return if the watch is established at the moment.
+   */
+  @Deprecated(forRemoval = true)
   boolean isWatching();
 
   boolean isRunning();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerWrapper.java

@@ -210,6 +210,7 @@ public boolean hasSynced() {
   }
 
   @Override
+  @Deprecated(forRemoval = true)
   public boolean isWatching() {
     return informer.isWatching();
   }