Fix #2623: Validate task decorator timeout values#2709
Open
1150654748m-dev wants to merge 1 commit into
Open
Conversation
- Add validation to ensure timeout is a positive number - Raise TypeError for non-numeric timeout values - Raise ValueError for zero or negative timeout values - Add comprehensive regression tests Fixes orchestration-agent#2623
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #2623 by adding validation to the
@taskdecorator to ensure timeout values are positive numbers.Problem
The
task()decorator accepted any value for thetimeoutparameter, including zero, negative numbers, and non-numeric types. This causedasyncio.wait_for()to fail immediately or behave unexpectedly when the decorated function was called.Solution
Added validation at decorator creation time:
TypeErrorif timeout is not a number (int or float)ValueErrorif timeout is zero or negativeChanges
src/sdk/decorators.py: Added validation logic totask()decoratortests/test_sdk_decorators.py: Comprehensive regression testsVerification
All tests pass:
Checklist
/bounty 000