Fix #2618: Reject blank agent names before POST#2710
Open
1150654748m-dev wants to merge 1 commit into
Open
Conversation
- Add validation to ensure agent name is a non-empty string - Raise TypeError for non-string name values - Raise ValueError for empty or whitespace-only names - Strip leading/trailing whitespace from valid names - Add comprehensive regression tests Fixes orchestration-agent#2618
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #2618 by adding validation to
OrchestratorClient.register_agent()to reject blank or whitespace-only agent names before making the POST request.Problem
The
register_agent()method accepted empty strings or whitespace-only values for thenameparameter, sending invalid registration requests to the API and cluttering logs and retry queues.Solution
Added validation at the beginning of
register_agent():TypeErrorif name is not a stringValueErrorif name is empty or whitespace-onlyChanges
src/sdk/client.py: Added validation logic toregister_agent()tests/test_sdk_client.py: Comprehensive regression testsVerification
All tests pass:
Checklist
/bounty 000