feat: add fixture sanitization linter for repository hygiene#3605
Open
hikali123456789 wants to merge 3 commits into
Open
feat: add fixture sanitization linter for repository hygiene#3605hikali123456789 wants to merge 3 commits into
hikali123456789 wants to merge 3 commits into
Conversation
- Scan test/src paths for prohibited patterns (API keys, emails, IPs, tokens) - Configurable prohibited pattern list with descriptions - Inline allow comments for false positive suppression - Human-readable violation report - Returns exit code for CI integration Fixes orchestration-agent#3570
- Test prohibited pattern detection (API keys, emails, IPs, tokens) - Test clean files produce no violations - Test dirty files are correctly flagged - Test inline allow comment suppression - Test safe email domains (test.com, example.com) - Test report generation
- Add 'make lint-fixture' command for CI integration - Runs fixture sanitization linter across test/src paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a fixture sanitization linter that scans test and source directories for prohibited patterns (API keys, real emails, tokens, IP addresses), preventing raw samples from accumulating in the repository.
Changes
tests/fixture_lint.py- Fixture sanitization linter# fixture-lint: allowcomments for false positive suppressiontests/test_fixture_lint.py- Comprehensive test suiteMakefile- Addedlint-fixtureCI targetmake lint-fixtureruns the linterAcceptance Criteria
Fixes #3570