[BUG] Card sync does not work as expected

[Phaust94]

Which app is your issue for

CardWallet

Version

1.12.2

What platform are you using?

iOS

OS Version

26.4.2

What happened?

iOS card sync overwrites remote state
STR:

1. On Android, create a 2 cards in 1 folder.
2. Add sync to webdav, then click "sync"
3. On a fresh iOS device, add webdav and click "sync". Observe both cards being downloaded.
4. Back on Android, delete one of the cards, click "sync"
5. Verify that the cards are deleted by opening the sync folder in the webdav client and seeing that there is only one folder (= 1 card data) in the sync folder.
6. Open iOS app, click "sync"

EXP: Remote changes from Android get pulled in, only 1 card remains
ACT: iOS state overwrites remote state, the card that was deleted gets re-uploaded to the webdav folder.

What I expect is that the priority (local vs remote state) get determined based on 2 timestamp fields: updated_time and sync_time, set on each of the cards both locally and on a remote.
Scenario A (Upload): Device A looks at a card and sees updated_time is newer than its last sync_time. It checks remote, and the remote version hasn't changed (remote sync_time = local sync_time). The Device A simply overwrites the file in the remote.
Scenario B (Download): Device B checks remote and finds a card where the remote updated_time is newer than Device B local sync_time. The Device B downloads it and updates its local database.
In case local updated_time is newer than local sync_time and remote sync_time is newer than local sync_time - a conflict is detected, remote changes are pulled and overwrite local changes, and also a new folder conflicts is created, and the local version of a conflicting card is moved there.
I hope it makes sense.

Code of Conduct

• I agree to follow this project's Code of Conduct

[farfromrefug]

@Phaust94 awesome report. Will fix that !

The logic about comparing timestamp is what is already implemented. What s failing for you there is the deletion. And it is a tricky subject because your second phone does not know at that point that it was on webdav but then removed. it sees it as "i have it but it is not on webdav => let s add it).
I thought i had it working though. Will check

[Phaust94]

Oh, I see. I guess soft deletes are the way to go here, which naturally ties into my previous suggestion about card archival (which is just soft deletes in disguise) :)

[farfromrefug]

@Phaust94 i am thinking i will implement a trash system. When you delete you will be prompted for delete/definitive delete.
I will also implement "history" of deletion on webdav that way deleted a sync document will be dispatched to other devices.
And with the trash/soft delete you will still have a copy on one device.
Just need to wrap it all up