[BUG] Documentnames with a "7" convert to pdf's with a "_" in filename at same characterposition

[joeldebruijn]

Sorry, couldnt get the bug template to work on github mobile.

App = Documentscanner
Version = 1.23.2 build 157
OS = Android 16

Bug:
When saved locally via sync the filenames replace the character 7 with a _

Name in app:

Filename:

[skaphle]

Somehow I didn't see this issue in the list, so I opened up another bug: #666

I have a few more observations there, e.g. it's not just "7" but also "f" and "x", and you can already see it in the export menu as the suggested file name.

[skaphle]

I looked at the code, and I think I found the issue here:

OSS-DocumentScanner/app/utils/utils.common.ts

Line 18 in 254a3e1

return str.replace(/[\x00-\x1f\x7f"*\/<>?\\:|\0x7f]+/g, wsRep).replace(/\s/g, wsRep);

The function cleanFilename is called and is supposed to replace bad characters with an underscore. There is this regex:
str.replace(/[\x00-\x1f\x7f"*/<>?\:|\0x7f]+/g, wsRep)

I don't know what the correct syntax should be, but \0x7f is probably wrong and leads to x, 7 and f characters being replaced. Can the part "\0x7f" just be removed?

[andyman1222]

I believe the fix for this issue is removing the 0 in \0x7f, ie \x7f. Checked with regexr.com. The regex is treating \0x7f as the null terminator \0 or x, 7 or f; removing the zero treats it as the delete character which is hex 0x7F. There might be other issues because \x7f is already included in the regex.

[farfromrefug]

@joeldebruijn @andyman1222 @skaphle indeed the regexp was wrong.
Will be fixed in next version