fix(history): handle json marshal errors, add logs

- Fixes errors in `RecordExecution` when failing to marshal headers/params
- Adds debug logs for validation failures
- Adds error log for timestamp parsing

Author: maniac-en

internal/crud/interfaces.go

@@ -1,3 +1,4 @@
+// Package crud provides generic CRUD operations for entities.
 package crud
 
 import (

internal/crud/interfaces_test.go

@@ -180,7 +180,6 @@ func TestCRUDValidation(t *testing.T) {
 	})
 }
 
-// Mock implementation for testing
 type testCRUDManager struct {
 	entities map[int64]TestEntity
 	nextID   int64

internal/crud/utils.go

@@ -3,21 +3,26 @@ package crud
 import (
 	"fmt"
 	"strings"
+
+	"github.com/maniac-en/req/internal/log"
 )
 
 func ValidateName(name string) error {
 	name = strings.TrimSpace(name)
 	if name == "" {
+		log.Debug("validation failed: empty name")
 		return fmt.Errorf("name cannot be empty")
 	}
 	if len(name) > 100 {
+		log.Debug("validation failed: name too long", "length", len(name))
 		return fmt.Errorf("name cannot exceed 100 characters")
 	}
 	return nil
 }
 
 func ValidateID(id int64) error {
 	if id <= 0 {
+		log.Debug("validation failed: invalid ID", "id", id)
 		return fmt.Errorf("ID must be positive")
 	}
 	return nil

internal/history/manager.go

@@ -95,7 +95,7 @@ func (h *HistoryManager) ListByCollection(ctx context.Context, collectionID int6
 	}
 
 	// Calculate pagination metadata
-	totalPages := int((total + int64(limit) - 1) / int64(limit))
+	totalPages := int((total + int64(limit) - 1) / int64(limit)) // Ceiling division
 	currentPage := (offset / limit) + 1
 	hasNext := (offset + limit) < int(total)
 	hasPrev := offset > 0
@@ -123,9 +123,21 @@ func (h *HistoryManager) RecordExecution(ctx context.Context, data ExecutionData
 
 	log.Debug("recording execution", "method", data.Method, "url", data.URL, "status", data.StatusCode)
 
-	requestHeaders, _ := json.Marshal(data.Headers)
-	queryParams, _ := json.Marshal(data.QueryParams)
-	responseHeaders, _ := json.Marshal(data.ResponseHeaders)
+	// Marshal to JSON for database storage
+	requestHeaders, err := json.Marshal(data.Headers)
+	if err != nil {
+		return HistoryEntity{}, fmt.Errorf("failed to marshal request headers: %w", err)
+	}
+	
+	queryParams, err := json.Marshal(data.QueryParams)
+	if err != nil {
+		return HistoryEntity{}, fmt.Errorf("failed to marshal query params: %w", err)
+	}
+	
+	responseHeaders, err := json.Marshal(data.ResponseHeaders)
+	if err != nil {
+		return HistoryEntity{}, fmt.Errorf("failed to marshal response headers: %w", err)
+	}
 
 	params := database.CreateHistoryEntryParams{
 		CollectionID:    sql.NullInt64{Int64: data.CollectionID, Valid: data.CollectionID > 0},
@@ -156,14 +168,17 @@ func (h *HistoryManager) RecordExecution(ctx context.Context, data ExecutionData
 
 func validateExecutionData(data ExecutionData) error {
 	if err := crud.ValidateName(data.Method); err != nil {
+		log.Debug("execution validation failed: invalid method", "method", data.Method)
 		return fmt.Errorf("invalid method: %w", err)
 	}
 
 	if err := crud.ValidateName(data.URL); err != nil {
+		log.Debug("execution validation failed: invalid URL", "url", data.URL)
 		return fmt.Errorf("invalid URL: %w", err)
 	}
 
 	if data.StatusCode < 100 || data.StatusCode > 599 {
+		log.Debug("execution validation failed: invalid status code", "status_code", data.StatusCode)
 		return fmt.Errorf("invalid status code: %d", data.StatusCode)
 	}
 

internal/history/manager_test.go

@@ -16,7 +16,7 @@ func setupTestDB(t *testing.T) *database.Queries {
 		t.Fatalf("failed to open in-memory database: %v", err)
 	}
 
-	// Create history table
+	// Use same schema as migration
 	schema := `
 	CREATE TABLE history (
 		id INTEGER PRIMARY KEY AUTOINCREMENT,

internal/history/models.go

@@ -1,9 +1,11 @@
+// Package history tracks HTTP request execution records.
 package history
 
 import (
 	"time"
 
 	"github.com/maniac-en/req/internal/database"
+	"github.com/maniac-en/req/internal/log"
 )
 
 type HistoryManager struct {
@@ -23,10 +25,15 @@ func (h HistoryEntity) GetName() string {
 }
 
 func (h HistoryEntity) GetCreatedAt() time.Time {
-	t, _ := time.Parse(time.RFC3339, h.ExecutedAt)
+	t, err := time.Parse(time.RFC3339, h.ExecutedAt)
+	if err != nil {
+		log.Error("failed to parse executed_at timestamp", "executed_at", h.ExecutedAt, "error", err)
+		return time.Time{}
+	}
 	return t
 }
 
+// GetUpdatedAt returns creation time since history entries are immutable
 func (h HistoryEntity) GetUpdatedAt() time.Time {
 	return h.GetCreatedAt()
 }