Feat/tabler+editable cols#2910
Draft
ElLorans wants to merge 27 commits into
Draft
Conversation
Merged from mariofix/flask-admin-tablerui Tabler version 1.4.0
…rts --disable-error-code name-defined --no-warn-unused-ignores --allow-subclassing-any examples
examples/tabler/main.py:73: error: Missing type parameters for generic type "dict" [type-arg]
meta_data: Mapped[dict] = mapped_column(JSON, default=dict, server_default=text("'{}'"))
^
Found 1 error in 1 file (checked 55 source files)
typing: exit 1 (23.45 seconds) /home/umpirsky/Projects/flask-admin> mypy --python-version 3.14 --ignore-missing-imports --disable-error-code name-defined --no-warn-unused-ignores --allow-subclassing-any examples pid=4036247
typing: FAIL code 1 (72.73=setup[2.26]+cmd[23.15,23.88,23.45] seconds)
evaluation failed :( (72.82 seconds)
style: venv> .venv/bin/uv venv -p /home/umpirsky/Projects/flask-admin/.venv/bin/python --allow-existing --python-preference system /home/umpirsky/Projects/flask-admin/.tox/style style: uv-sync> uv sync --locked --python-preference system --extra all --no-default-groups --no-editable --reinstall-package Flask-Admin --group pre-commit -p /home/umpirsky/Projects/flask-admin/.venv/bin/python style: commands[0]> pre-commit run --all-files [INFO] Initializing environment for https://github.com/astral-sh/ruff-pre-commit. [INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Installing environment for https://github.com/astral-sh/ruff-pre-commit. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Using pre-commit with uv 0.11.6 via pre-commit-uv 4.2.0 [INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks. [INFO] Once installed this environment will be reused. [INFO] This may take a few minutes... [INFO] Using pre-commit with uv 0.11.6 via pre-commit-uv 4.2.0 ruff.....................................................................Failed - hook id: ruff - exit code: 1 - files were modified by this hook examples/tabler/main.py:69:89: E501 Line too long (102 > 88) | 67 | title: Mapped[str] = mapped_column(String(64)) 68 | content: Mapped[Text] = mapped_column(Text) 69 | meta_data: Mapped[dict[str, Any]] = mapped_column(JSON, default=dict, server_default=text("'{}'")) | ^^^^^^^^^^^^^^ E501 70 | 71 | def __repr__(self): | examples/tabler/main.py:178:89: E501 Line too long (89 > 88) | 176 | # admin.add_menu_item(MenuDivider(), target_category="Links") 177 | # admin.add_link( 178 | # MenuLink(name="External link", url="http://www.example.com/", category="Links") | ^ E501 179 | # ) | flask_admin/tests/tabler/test_renders.py:64:89: E501 Line too long (92 > 88) | 62 | ], 63 | ), 64 | ("condensed", ["data-tabler-layout=\"condensed\"", "tabler-admin-navbar-collapse"]), | ^^^^ E501 65 | ], 66 | ) | Fixed 7 errors: - examples/tabler/main.py: 5 × F401 (unused-import) 1 × I001 (unsorted-imports) - flask_admin/tests/tabler/test_renders.py: 1 × I001 (unsorted-imports) Found 10 errors (7 fixed, 3 remaining). ruff-format..............................................................Failed - hook id: ruff-format - files were modified by this hook 4 files reformatted, 167 files left unchanged check for merge conflicts................................................Passed debug statements (python)................................................Passed fix utf-8 byte order marker..............................................Passed trim trailing whitespace.................................................Passed fix end of files.........................................................Failed - hook id: end-of-file-fixer - exit code: 1 - files were modified by this hook Fixing flask_admin/tests/tabler/__init__.py style: exit 1 (10.35 seconds) /home/umpirsky/Projects/flask-admin> pre-commit run --all-files pid=4052435 style: FAIL code 1 (12.66=setup[2.31]+cmd[10.35] seconds) evaluation failed :( (12.72 seconds)
…-oren' into tabler-ui
This was referenced May 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a drat attempting to combine #2847 and #2892