Callable timeout#401
Open
thejeremyjohn wants to merge 6 commits into
Open
Conversation
Member
|
Hey @thejeremyjohn, thanks for the contribution! It looks like we are failing some tests, could you please take a look? |
Author
|
Hi @northernSage. Yw -- I'm glad to do it! Yeah, that's consistent with what I noted in the PR. Whatever is failing there is not related to the callable timeout changes. It's only tripping because those tests are running rather than being skipped due to |
Author
|
@northernSage Please let me know if that ^^^ is the preferred way to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
timeoutin@cachedand@memoizedA callable
timeoutserves a similar purpose toCachedResponse(introduced in PR #296) but does not replace that functionality entirely. These are the differences:A
CachedResponsealways takes priority over callabletimeoutif it is the sole rv type so there's no point in using both in that case. However if the rv type is conditional they could be complimentary.NOTE: Prior to this PR,
tests/test_backend_cache.py::TestRedisCache::test_generic_inc_decare skipped if pytest-xprocess can't be imported but with that import fixed (1st commit in this PR), they actually fail. (I did not investigate further. FWIW I'm runningRedis version=7.0.0) That is why the below box is unchecked, but all other tests pass.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.