Skip to content
This repository was archived by the owner on May 11, 2022. It is now read-only.
This repository was archived by the owner on May 11, 2022. It is now read-only.

.git.frozen.tgz should NOT be added to repo while freezing #6

@ramnathv

Description

@ramnathv

First off, great work with giternal. It was exactly the tool I was looking for to manage vendoring in a simple, yet flexible manner. The one issue I encountered was the inclusion of .git.frozen.tgz in the main repo, when it is frozen. I believe this is the line responsible for that happening.

https://github.com/patmaddox/giternal/blob/master/lib/giternal/repository.rb#L53

IMHO, I don't think this should be included in the main repo, since it is only to keep track of the history of the dependencies. By including this in the main repo, any push commands push the entire repo along with the history of all the dependencies, which is not desirable.

I managed a workaround by manually calling git checkout .git.frozen.tgz for all the vendored libraries, but a more elegant solution would be to build this into the rubygem.

Let me know your thoughts.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions