Skip to content

Commit 351df49

Browse files
fix(PencilAltIcon): Replace PencilAltIcon with RhUiEditFillIcon (#12467)
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent a2798bd commit 351df49

4 files changed

Lines changed: 13 additions & 37 deletions

File tree

packages/react-table/src/components/Table/EditColumn.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { Fragment } from 'react';
22
import { Button } from '@patternfly/react-core/dist/esm/components/Button';
3-
import PencilAltIcon from '@patternfly/react-icons/dist/esm/icons/pencil-alt-icon';
3+
import RhUiEditFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-edit-fill-icon';
44
import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon';
55
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
66
import { OnRowEdit } from './TableTypes';
@@ -57,7 +57,7 @@ export const EditColumn: React.FunctionComponent<EditColumnProps> = ({
5757
{...props}
5858
onClick={(e) => onClick(e, 'edit')}
5959
variant="plain"
60-
icon={<PencilAltIcon />}
60+
icon={<RhUiEditFillIcon />}
6161
/>
6262
</div>
6363
</Fragment>

packages/react-table/src/components/Table/examples/Table.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ import FolderOpenIcon from '@patternfly/react-icons/dist/esm/icons/folder-open-i
5252
import SortAmountDownIcon from '@patternfly/react-icons/dist/esm/icons/sort-amount-down-icon';
5353
import RhUiBlueprintIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-blueprint-icon';
5454
import EllipsisVIcon from '@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon';
55-
import PencilAltIcon from '@patternfly/react-icons/dist/esm/icons/pencil-alt-icon';
55+
import RhUiEditFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-edit-fill-icon';
5656
import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon';
5757
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
5858

packages/react-table/src/components/Table/examples/TableEditable.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { isValidElement, useRef, useState } from 'react';
22
import { Table, Thead, Tr, Th, Tbody, Td } from '@patternfly/react-table';
33
import { Button, Checkbox, Radio, TextInput, KeyTypes, getUniqueId } from '@patternfly/react-core';
4-
import PencilAltIcon from '@patternfly/react-icons/dist/esm/icons/pencil-alt-icon';
4+
import RhUiEditFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-edit-fill-icon';
55
import CheckIcon from '@patternfly/react-icons/dist/esm/icons/check-icon';
66
import RhMicronsCloseIcon from '@patternfly/react-icons/dist/esm/icons/rh-microns-close-icon';
77
import inlineEditStyles from '@patternfly/react-styles/css/components/InlineEdit/inline-edit';
@@ -75,7 +75,7 @@ const EditButtonsCell: React.FunctionComponent<EditButtonsCellProps> = ({
7575
onKeyDown={(event) => onKeyDown(event, 'edit')}
7676
variant="plain"
7777
>
78-
<PencilAltIcon />
78+
<RhUiEditFillIcon />
7979
</Button>
8080
</Td>
8181
</>

packages/react-table/src/deprecated/components/Table/__tests__/__snapshots__/Table.test.tsx.snap

Lines changed: 8 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -11124,24 +11124,12 @@ exports[`Table simple Editable table 1`] = `
1112411124
fill="currentColor"
1112511125
height="1em"
1112611126
role="img"
11127+
viewBox="0 0 32 32"
1112711128
width="1em"
1112811129
>
11129-
<svg
11130-
class="pf-v6-icon-default"
11131-
viewBox="0 0 512 512"
11132-
>
11133-
<path
11134-
d="M497.9 142.1l-46.1 46.1c-4.7 4.7-12.3 4.7-17 0l-111-111c-4.7-4.7-4.7-12.3 0-17l46.1-46.1c18.7-18.7 49.1-18.7 67.9 0l60.1 60.1c18.8 18.7 18.8 49.1 0 67.9zM284.2 99.8L21.6 362.4.4 483.9c-2.9 16.4 11.4 30.6 27.8 27.8l121.5-21.3 262.6-262.6c4.7-4.7 4.7-12.3 0-17l-111-111c-4.8-4.7-12.4-4.7-17.1 0zM124.1 339.9c-5.5-5.5-5.5-14.3 0-19.8l154-154c5.5-5.5 14.3-5.5 19.8 0s5.5 14.3 0 19.8l-154 154c-5.5 5.5-14.3 5.5-19.8 0zM88 424h48v36.3l-64.5 11.3-31.1-31.1L51.7 376H88v48z"
11135-
/>
11136-
</svg>
11137-
<svg
11138-
class="pf-v6-icon-rh-ui"
11139-
viewBox="0 0 32 32"
11140-
>
11141-
<path
11142-
d="m29.354 6.939-4.293-4.293a1.501 1.501 0 0 0-2.121 0L6.293 19.293a.98.98 0 0 0-.225.358l-3.981 8.942c-.004.008-.002.017-.006.025-.029.07-.036.145-.049.22-.009.055-.029.107-.028.162 0 .054.019.107.028.162.013.075.02.15.049.22.003.008.002.017.006.025.044.1.105.188.175.265.013.015.031.025.045.039a.985.985 0 0 0 .246.175c.015.008.025.022.041.029.014.006.029.004.044.009a.994.994 0 0 0 .357.077h.008a.973.973 0 0 0 .357-.077c.014-.006.03-.003.044-.009l8.943-3.982a.98.98 0 0 0 .357-.225l16.65-16.647c.283-.283.439-.66.439-1.061s-.156-.777-.439-1.061ZM4.972 27.027l2.354-5.287 2.933 2.933-5.287 2.354ZM12 23.586 8.414 20 20.5 7.914l3.586 3.586L12 23.586Zm13.5-13.5L21.914 6.5 24 4.414 27.586 8 25.5 10.086Z"
11143-
/>
11144-
</svg>
11130+
<path
11131+
d="M19.061 8.646a1.501 1.501 0 0 0-2.121 0L6.294 19.292a.98.98 0 0 0-.225.358l-3.981 8.942c-.004.008-.002.017-.006.025-.029.07-.036.145-.049.22-.009.055-.029.107-.028.162 0 .054.019.107.028.162.013.075.02.15.049.22.003.008.002.017.006.025.044.1.105.188.175.265.013.015.031.025.045.039a.985.985 0 0 0 .246.175c.015.008.025.022.041.029.014.006.029.004.044.009a.994.994 0 0 0 .357.077h.008a.973.973 0 0 0 .357-.077c.014-.006.03-.003.044-.009l8.943-3.982a.98.98 0 0 0 .357-.225l10.646-10.646c.283-.283.439-.66.439-1.061s-.156-.777-.439-1.061l-4.293-4.293ZM7.326 21.74l2.933 2.933-5.287 2.354 2.354-5.287ZM29.793 8c0 .4-.156.777-.439 1.061l-2.293 2.293c-.292.292-.677.438-1.061.438s-.769-.146-1.061-.438l-4.293-4.293c-.283-.283-.439-.66-.439-1.061s.156-.777.439-1.061l2.293-2.293a1.501 1.501 0 0 1 2.121 0l4.293 4.293c.283.283.439.66.439 1.061Z"
11132+
/>
1114511133
</svg>
1114611134
</span>
1114711135
</button>
@@ -11388,24 +11376,12 @@ exports[`Table simple Editable table 1`] = `
1138811376
fill="currentColor"
1138911377
height="1em"
1139011378
role="img"
11379+
viewBox="0 0 32 32"
1139111380
width="1em"
1139211381
>
11393-
<svg
11394-
class="pf-v6-icon-default"
11395-
viewBox="0 0 512 512"
11396-
>
11397-
<path
11398-
d="M497.9 142.1l-46.1 46.1c-4.7 4.7-12.3 4.7-17 0l-111-111c-4.7-4.7-4.7-12.3 0-17l46.1-46.1c18.7-18.7 49.1-18.7 67.9 0l60.1 60.1c18.8 18.7 18.8 49.1 0 67.9zM284.2 99.8L21.6 362.4.4 483.9c-2.9 16.4 11.4 30.6 27.8 27.8l121.5-21.3 262.6-262.6c4.7-4.7 4.7-12.3 0-17l-111-111c-4.8-4.7-12.4-4.7-17.1 0zM124.1 339.9c-5.5-5.5-5.5-14.3 0-19.8l154-154c5.5-5.5 14.3-5.5 19.8 0s5.5 14.3 0 19.8l-154 154c-5.5 5.5-14.3 5.5-19.8 0zM88 424h48v36.3l-64.5 11.3-31.1-31.1L51.7 376H88v48z"
11399-
/>
11400-
</svg>
11401-
<svg
11402-
class="pf-v6-icon-rh-ui"
11403-
viewBox="0 0 32 32"
11404-
>
11405-
<path
11406-
d="m29.354 6.939-4.293-4.293a1.501 1.501 0 0 0-2.121 0L6.293 19.293a.98.98 0 0 0-.225.358l-3.981 8.942c-.004.008-.002.017-.006.025-.029.07-.036.145-.049.22-.009.055-.029.107-.028.162 0 .054.019.107.028.162.013.075.02.15.049.22.003.008.002.017.006.025.044.1.105.188.175.265.013.015.031.025.045.039a.985.985 0 0 0 .246.175c.015.008.025.022.041.029.014.006.029.004.044.009a.994.994 0 0 0 .357.077h.008a.973.973 0 0 0 .357-.077c.014-.006.03-.003.044-.009l8.943-3.982a.98.98 0 0 0 .357-.225l16.65-16.647c.283-.283.439-.66.439-1.061s-.156-.777-.439-1.061ZM4.972 27.027l2.354-5.287 2.933 2.933-5.287 2.354ZM12 23.586 8.414 20 20.5 7.914l3.586 3.586L12 23.586Zm13.5-13.5L21.914 6.5 24 4.414 27.586 8 25.5 10.086Z"
11407-
/>
11408-
</svg>
11382+
<path
11383+
d="M19.061 8.646a1.501 1.501 0 0 0-2.121 0L6.294 19.292a.98.98 0 0 0-.225.358l-3.981 8.942c-.004.008-.002.017-.006.025-.029.07-.036.145-.049.22-.009.055-.029.107-.028.162 0 .054.019.107.028.162.013.075.02.15.049.22.003.008.002.017.006.025.044.1.105.188.175.265.013.015.031.025.045.039a.985.985 0 0 0 .246.175c.015.008.025.022.041.029.014.006.029.004.044.009a.994.994 0 0 0 .357.077h.008a.973.973 0 0 0 .357-.077c.014-.006.03-.003.044-.009l8.943-3.982a.98.98 0 0 0 .357-.225l10.646-10.646c.283-.283.439-.66.439-1.061s-.156-.777-.439-1.061l-4.293-4.293ZM7.326 21.74l2.933 2.933-5.287 2.354 2.354-5.287ZM29.793 8c0 .4-.156.777-.439 1.061l-2.293 2.293c-.292.292-.677.438-1.061.438s-.769-.146-1.061-.438l-4.293-4.293c-.283-.283-.439-.66-.439-1.061s.156-.777.439-1.061l2.293-2.293a1.501 1.501 0 0 1 2.121 0l4.293 4.293c.283.283.439.66.439 1.061Z"
11384+
/>
1140911385
</svg>
1141011386
</span>
1141111387
</button>

0 commit comments

Comments
 (0)