From cb49d3dd84f96a1cf91c6479c04a6af673116728 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Sun, 2 Oct 2022 22:56:43 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- .../pygments/lexers/_php_builtins.py | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py b/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py index 44ef205..ac6f9d3 100644 --- a/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py +++ b/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py @@ -4728,7 +4728,26 @@ def get_php_functions(): def get_php_references(): download = urlretrieve(PHP_MANUAL_URL) with tarfile.open(download[0]) as tar: - tar.extractall() + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(tar) for file in glob.glob("%s%s" % (PHP_MANUAL_DIR, PHP_REFERENCE_GLOB)): yield file os.remove(download[0]) From b1d7922ba58fd9fa70433242ba1dc5259a4f999e Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Tue, 4 Oct 2022 20:39:02 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- .../python3.7/site-packages/pygments/lexers/_php_builtins.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py b/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py index ac6f9d3..5413145 100644 --- a/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py +++ b/tree_env/lib/python3.7/site-packages/pygments/lexers/_php_builtins.py @@ -4744,7 +4744,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(tar)