Skip to content

assigning certain properties to constructor will fail #22

@neonstalwart

Description

@neonstalwart

in FacetedStore there is a for loop to copy properties from facetSchema to constructor. if facetSchema contains certain properties (name, caller, length, etc) an error will be thrown in strict mode.

    for(i in facetSchema){
        constructor[i] = facetSchema[i];
    }

most of these properties are unlikely to be in a schema except that i came across this because i was using name in my schemas. should we just wrap that assignment in a try/catch to silence the errors?

    for(i in facetSchema){
        try {
            constructor[i] = facetSchema[i];
        }
        catch (e) {}
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions