[Feature] Increase width at max width automatically maximize the window

[jinliu]

The basic idea is to treat "maximized" state as "max+1" column width, i.e., "bigger than the biggest size", so the normal increase/decrease column width hotkeys can also serve as maximize/restore.

Personally, I think this is more intuitive than having column width and maximize as orthogonal states. I.e., if I increase the column size to max, and still want it bigger, then the next logical step seems to be maximizing.

Specifically:

1. If the active column has only one window, and currently at max width, then pressing "Increase column width" or "Cycle through preset column widths" maximizes it.
2. If the active window is maximized, then:
   2.1. Pressing "Increase column width" or "Equalize visible column widths" has no effect.
   2.2. Pressing "Decrease column width" or "Cycle in reverse through preset column widths" restores it.
   2.3. Pressing "Cycle through preset column widths" restores it and sets it to the smallest preset column width.
   2.4. Other hotkeys that would change column width, now restores the window first. Including: "Move window to *", "Squeeze left/right column onto the screen".

Questions:

1. Whether this should be behind an option? Probably yes, since this is a pretty big change from the current behaviour.
2. Shall we also consider "fullscreen" as "max+2", i.e., "Increase column width" on a maximized window would fullscreen it? If so, should this be behind another option?

I'd be glad to implement this if you like the idea.

[peterfajdiga]

Thanks for the suggestion. It makes sense in the sense that a maximized window is "bigger than the biggest size". But I don't want to treat maximized as a column width state for multiple reasons:

• increasing column width enlarges all the windows in the column, so I don't think the final step should act differently and enlarge only the focused window
• in my opinion, maximized is useful for making a window temporarily as big as possible, then reverting everything back to the way it was
• it would complicate the code and make Karousel harder to maintain

But I like the points 2.2, 2.3, 2.4 - it would make sense to unmaximize the window before changing column widths. In fact, it would make sense to unmaximize the window before any layout manipulation - even just switching focused windows (this was implemented in the past, but has stopped working at some point).