Fixed typos, an oversight regarding nltk data download, and added support for multi-threading/processing, Windows, ignoring UTF-8 decoding failures, etc.#47
Open
Trenza1ore wants to merge 20 commits into
Conversation
…ments to use proper formats
…nction to return logging message instead of appending to log file directly
…ia an optional `--procedures` argument
…omization and multi-threading/processing support in progress
Trenza1ore
changed the title
…" codecs such as Windows-1252
…multi-threading or processing, argument for ignoring UTF-8 decoding failures
Trenza1ore
changed the title
…tility function for checking if a file is empty
…re assuming a book is "done"
- used `shutil.rmtree` instead of `os.rmdir` since latter is only for empty dir and added check for existence of dir to remove (win32) - removed `-p` option when calling wget to avoid downloading large amount of useless data (original code) - filtered out many garbage data (non-book weblinks) in bookshelves dicts and removed "PG" prefix for values of index.html in bookshelves_ebooks_dict.pkl (original code)
… bookshelves info without running time-consuming Wget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are described in commit messages