Inital review feedback

  - remove the zend_always_inline
  - use INT_MIN instead of -INT_MAX
  - use % matching in the tests so they work on 32bit

Author: edorian

ext/bcmath/bcmath.c

@@ -155,10 +155,10 @@ static zend_always_inline zend_result bcmath_check_scale(zend_long scale, uint32
 	return SUCCESS;
 }
 
-static zend_always_inline zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num)
+static zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num)
 {
-	if (UNEXPECTED(precision < -(zend_long) INT_MAX || precision > INT_MAX)) {
-		zend_argument_value_error(arg_num, "must be between %d and %d", -INT_MAX, INT_MAX);
+	if (UNEXPECTED(precision < INT_MIN || precision > INT_MAX)) {
+		zend_argument_value_error(arg_num, "must be between %d and %d", INT_MIN, INT_MAX);
 		return FAILURE;
 	}
 	return SUCCESS;

ext/bcmath/tests/bcround_precision_bounds.phpt

@@ -25,8 +25,8 @@ try {
     echo $e->getMessage() . \PHP_EOL;
 }
 ?>
---EXPECT--
-bcround(): Argument #2 ($precision) must be between -2147483647 and 2147483647
-bcround(): Argument #2 ($precision) must be between -2147483647 and 2147483647
-bcround(): Argument #2 ($precision) must be between -2147483647 and 2147483647
-BcMath\Number::round(): Argument #1 ($precision) must be between -2147483647 and 2147483647
+--EXPECTF--
+bcround(): Argument #2 ($precision) must be between %i and %i
+bcround(): Argument #2 ($precision) must be between %i and %i
+bcround(): Argument #2 ($precision) must be between %i and %i
+BcMath\Number::round(): Argument #1 ($precision) must be between %i and %i