ext/spl: Use zend_hash_add() for missing array keys

arshidkv12 · arshidkv12 · commit 67fc06759b7a · 2026-03-26T11:08:47.000+05:30
diff --git a/ext/xml/xml.c b/ext/xml/xml.c
@@ -557,7 +557,7 @@ static void xml_add_to_info(xml_parser *parser, zend_string *name)
 	if ((element = zend_hash_find(arr, name)) == NULL) {
 		zval values;
 		array_init(&values);
-		element = zend_hash_update(arr, name, &values);
+		element = zend_hash_add(arr, name, &values);
 	}
 
 	add_next_index_long(element, parser->curtag);

Original file line number	Diff line number	Diff line change
`@@ -557,7 +557,7 @@ static void xml_add_to_info(xml_parser parser, zend_string name)`
`557`	`557`	`if ((element = zend_hash_find(arr, name)) == NULL) {`
`558`	`558`	`zval values;`
`559`	`559`	`array_init(&values);`
`560`		`- element = zend_hash_update(arr, name, &values);`
	`560`	`+ element = zend_hash_add(arr, name, &values);`
`561`	`561`	`}`
`562`	`562`
`563`	`563`	`add_next_index_long(element, parser->curtag);`