Microoptimize port validation

kocsismate · kocsismate · commit 792982003a58 · 2026-06-14T14:16:06.000+02:00
diff --git a/ext/uri/uri_parser_rfc3986.c b/ext/uri/uri_parser_rfc3986.c
@@ -760,11 +760,10 @@ ZEND_ATTRIBUTE_NONNULL zend_result php_uri_parser_rfc3986_validate_host(const ze
 
 ZEND_ATTRIBUTE_NONNULL zend_result php_uri_parser_rfc3986_validate_port(const zend_long port)
 {
-	zend_string *tmp = zend_long_to_str(port);
-	const char *p = ZSTR_VAL(tmp);
-	const size_t len = ZSTR_LEN(tmp);
-	const bool well_formed = uriIsWellFormedPortA(p, p + len);
-	zend_string_release(tmp);
+	char buf[MAX_LENGTH_OF_LONG + 1];
+	const char *res = zend_print_long_to_buf(buf + sizeof(buf) - 1, port);
+
+	const bool well_formed = uriIsWellFormedPortA(res, res + strlen(res));
 
 	return php_uri_parser_rfc3986_validate_component_result(well_formed, "port");
 }

Original file line number	Diff line number	Diff line change
`@@ -760,11 +760,10 @@ ZEND_ATTRIBUTE_NONNULL zend_result php_uri_parser_rfc3986_validate_host(const ze`
`760`	`760`
`761`	`761`	`ZEND_ATTRIBUTE_NONNULL zend_result php_uri_parser_rfc3986_validate_port(const zend_long port)`
`762`	`762`	`{`
`763`		`- zend_string *tmp = zend_long_to_str(port);`
`764`		`- const char *p = ZSTR_VAL(tmp);`
`765`		`- const size_t len = ZSTR_LEN(tmp);`
`766`		`- const bool well_formed = uriIsWellFormedPortA(p, p + len);`
`767`		`- zend_string_release(tmp);`
	`763`	`+ char buf[MAX_LENGTH_OF_LONG + 1];`
	`764`	`+ const char *res = zend_print_long_to_buf(buf + sizeof(buf) - 1, port);`
	`765`	`+`
	`766`	`+ const bool well_formed = uriIsWellFormedPortA(res, res + strlen(res));`
`768`	`767`
`769`	`768`	`return php_uri_parser_rfc3986_validate_component_result(well_formed, "port");`
`770`	`769`	`}`