ext/phar: avoid redundant allocation by using zend_string for alias

arshidkv12 · arshidkv12 · commit 9aef6eb18d88 · 2026-04-18T18:34:36.000+05:30
diff --git a/ext/phar/phar_object.c b/ext/phar/phar_object.c
@@ -1072,7 +1072,7 @@ static const spl_other_handler phar_spl_foreign_handler = {
 PHP_METHOD(Phar, __construct)
 {
 	char *fname, *error, *save_fname;
-	size_t fname_len, alias_len = 0;
+	size_t fname_len;
 	bool is_data;
 	zend_long flags = SPL_FILE_DIR_SKIPDOTS|SPL_FILE_DIR_UNIXPATHS;
 	zend_long format = 0;
diff --git a/ext/phar/tar.c b/ext/phar/tar.c
@@ -1049,7 +1049,7 @@ ZEND_ATTRIBUTE_NONNULL_ARGS(1, 4) int phar_tar_flush(phar_archive_data *phar, ze
 	}
 
 	/* set alias */
-	if (!phar->is_temporary_alias && phar) {
+	if (phar && !phar->is_temporary_alias) {
 		entry.fp = php_stream_fopen_tmpfile();
 		if (entry.fp == NULL) {
 			*error = estrdup("phar error: unable to create temporary file");

Original file line number	Diff line number	Diff line change
`@@ -1072,7 +1072,7 @@ static const spl_other_handler phar_spl_foreign_handler = {`
`1072`	`1072`	`PHP_METHOD(Phar, __construct)`
`1073`	`1073`	`{`
`1074`	`1074`	`char fname, error, *save_fname;`
`1075`		`- size_t fname_len, alias_len = 0;`
	`1075`	`+ size_t fname_len;`
`1076`	`1076`	`bool is_data;`
`1077`	`1077`	`zend_long flags = SPL_FILE_DIR_SKIPDOTS\|SPL_FILE_DIR_UNIXPATHS;`
`1078`	`1078`	`zend_long format = 0;`
Original file line number	Diff line number	Diff line change
`@@ -1049,7 +1049,7 @@ ZEND_ATTRIBUTE_NONNULL_ARGS(1, 4) int phar_tar_flush(phar_archive_data *phar, ze`
`1049`	`1049`	`}`
`1050`	`1050`
`1051`	`1051`	`/* set alias */`
`1052`		`- if (!phar->is_temporary_alias && phar) {`
	`1052`	`+ if (phar && !phar->is_temporary_alias) {`
`1053`	`1053`	`entry.fp = php_stream_fopen_tmpfile();`
`1054`	`1054`	`if (entry.fp == NULL) {`
`1055`	`1055`	`*error = estrdup("phar error: unable to create temporary file");`