switch to ValueError

Author: LamentXU123

ext/standard/link.c

@@ -85,8 +85,8 @@ PHP_FUNCTION(linkinfo)
 	ZEND_PARSE_PARAMETERS_END();
 
 	if (UNEXPECTED(link_len == 0)) {
-		php_error_docref(NULL, E_WARNING, "%s", strerror(ENOENT));
-		RETURN_LONG(Z_L(-1));
+		zend_argument_must_not_be_empty_error(1);
+		RETURN_THROWS();
 	}
 
 	dirname = estrndup(link, link_len);

ext/standard/tests/file/symlink_link_linkinfo_is_link_error1.phpt

@@ -27,8 +27,16 @@ var_dump( symlink($filename, false) );  // false as linkname
 echo "\n*** Testing linkinfo() for error conditions ***\n";
 
 //invalid arguments
-var_dump( linkinfo('') );  // empty string as linkname
-var_dump( linkinfo(false) );  // boolean false as linkname
+try {
+    var_dump(linkinfo(''));  // empty string as linkname
+} catch (ValueError $e) {
+    echo $e->getMessage() . "\n";
+}
+try {
+    var_dump(linkinfo(false));  // boolean false as linkname
+} catch (ValueError $e) {
+    echo $e->getMessage() . "\n";
+}
 
 echo "Done\n";
 ?>
@@ -54,9 +62,6 @@ bool(false)
 
 *** Testing linkinfo() for error conditions ***
 
-Warning: linkinfo(): %s in %s on line %d
-int(-1)
-
-Warning: linkinfo(): %s in %s on line %d
-int(-1)
+linkinfo(): Argument #1 ($path) must not be empty
+linkinfo(): Argument #1 ($path) must not be empty
 Done