Consider adding Drupal to community build

[hestenet]

Description

In the same way that wordpress was added to the community build in: #9942, it would be good to add Drupal as well, to help catch potential incompatibilities early.

[iluuu1994]

Note that the community builds are about catching memory corruption and undefined behavior, not incompatibilities. In fact, we completely ignore test failures.

[andypost]

Drupal is complex software so it could be helpful to catch edge cases

[iluuu1994]

Certainly. Just wanted to mention that it will not help with catching incompatibilities between PHP versions.

[cmb69]

Note that the community builds are about catching memory corruption and undefined behavior, not incompatibilities.

That. Drupal and others can set up their own suites running against php-src/master if they whish.

[cmb69]

Maybe someone accustomed to the Drupal test suite wants to provide a PR?

[andypost]

I could work on it this weekend, I think we can run kernel and functional tests as unit ones are not much helpful

[andypost]

is there a limit on job? Addition of kernel tests" will consume extra 4 hours

• https://github.com/php/php-src/actions/runs/3618257801/jobs/6097906819
• https://github.com/php/php-src/actions/runs/3618257801/jobs/6097906922

ATM running unit and build tests (each suite takes ~5 mins) should be enough as "build tests" making install using SIMPLETEST_DB environment variable

Current numbers are https://github.com/php/php-src/actions/runs/3619347838/jobs/6100285224

sqlite
Tests: 19452, Assertions: 34554, Failures: 4, Skipped: 2585, Incomplete: 3.
mysql
Tests: 19452, Assertions: 34545, Errors: 2, Failures: 4, Skipped: 2585, Incomplete: 3.
pgsql
Tests: 19452, Assertions: 34551, Failures: 4, Skipped: 2585, Incomplete: 3.

[iluuu1994]

is there a limit on job? Addition of kernel tests" will consume extra 4 hours

Yes, the limit is 6 hours. Also note that a build with the sanitize flags will run significantly slower (~2x).

[andypost]

Is there a reason why in CI the build-in webserver reports "HTTP/0.9"?

GuzzleHttp\Exception\RequestException: cURL error 1: Received HTTP/0.9 when not allowed
 (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for http://localhost:8080/core/install.php

from https://github.com/php/php-src/actions/runs/3620190741/jobs/6102128048

[cmb69]

Is there a reason why in CI the build-in webserver reports "HTTP/0.9"?

php-src/sapi/cli/php_cli_server.c

Line 704 in 4ae1f08

zend_string *tmp = strpprintf(0, "HTTP/%d.%d", client->request.protocol_version / 100, client->request.protocol_version % 100);

So the built-in Webserver responds according to the request.

[andypost]

Now I made it work, and looks only kernel tests can catch errors, for example run https://github.com/php/php-src/actions/runs/3618257801/jobs/6097906819

 1) Drupal\KernelTests\Core\Asset\ResolvedLibraryDefinitionsFilesMatchTest::testCoreLibraryCompleteness
PHPUnit\Framework\Exception: php: /home/runner/work/php-src/php-src/Zend/zend_types.h:1221: zend_gc_delref: Assertion `p->refcount > 0' failed.
Aborted (core dumped)
...
2) Drupal\KernelTests\Core\Extension\ModuleConfigureRouteTest::testModuleConfigureRoutes with data set "responsive_image" ('responsive_image')
PHPUnit\Framework\Exception: php: /home/runner/work/php-src/php-src/Zend/zend_types.h:1221: zend_gc_delref: Assertion `p->refcount > 0' failed.
Aborted (core dumped)
...
3) Drupal\KernelTests\Core\Theme\Stable9LibraryOverrideTest::testStable9LibraryOverrides
PHPUnit\Framework\Exception: php: /home/runner/work/php-src/php-src/Zend/zend_types.h:1221: zend_gc_delref: Assertion `p->refcount > 0' failed.
Aborted (core dumped)
...
 4) Drupal\Tests\content_moderation\Kernel\InitialStateTest::testInitialState
PHPUnit\Framework\Exception: php: /home/runner/work/php-src/php-src/Zend/zend_types.h:1221: zend_gc_delref: Assertion `p->refcount > 0' failed.
Aborted (core dumped)
...
5) Drupal\Tests\taxonomy\Kernel\VocabularyCrudTest::testUninstallReinstall
PHPUnit\Framework\Exception: php: /home/runner/work/php-src/php-src/Zend/zend_types.h:1221: zend_gc_delref: Assertion `p->refcount > 0' failed.
Aborted (core dumped)

probably concurrency can cause it

[iluuu1994]

There's a WIP PR here #10050, so I'm closing this issue.