diff --git a/ext/sockets/conversions.c b/ext/sockets/conversions.c index d6f208d69868..61a76fb4893e 100644 --- a/ext/sockets/conversions.c +++ b/ext/sockets/conversions.c @@ -1270,11 +1270,10 @@ static void from_zval_write_ifindex(const zval *zv, char *uinteger, ser_context #elif defined(SIOCGIFINDEX) { struct ifreq ifr; - if (ZSTR_LEN(str) >= sizeof(ifr.ifr_name)) { + if (strlcpy(ifr.ifr_name, ZSTR_VAL(str), sizeof(ifr.ifr_name)) + >= sizeof(ifr.ifr_name)) { do_from_zval_err(ctx, "the interface name \"%s\" is too large ", ZSTR_VAL(str)); - } - memcpy(ifr.ifr_name, ZSTR_VAL(str), ZSTR_LEN(str) + 1); - if (ioctl(ctx->sock->bsd_socket, SIOCGIFINDEX, &ifr) < 0) { + } else if (ioctl(ctx->sock->bsd_socket, SIOCGIFINDEX, &ifr) < 0) { if (errno == ENODEV) { do_from_zval_err(ctx, "no interface with name \"%s\" could be " "found", ZSTR_VAL(str));