From fbdc5ed08f7c35d3d2785bce88be72a06e648e9f Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Tue, 2 Jun 2026 15:04:42 -0700
Subject: [PATCH 1/4] Use correct IN_ADMIN constant

---
 event/listener.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/event/listener.php b/event/listener.php
index 2462f6e..714ee22 100644
--- a/event/listener.php
+++ b/event/listener.php
@@ -126,6 +126,6 @@ public function inject_frontend()
 	 */
 	protected function is_acp_or_installer()
 	{
-		return defined('ADMIN_START') || defined('IN_INSTALL');
+		return defined('IN_ADMIN') || defined('IN_INSTALL');
 	}
 }

From 8a9da4b106c4c9729babcb15dd6be72725b729ff Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Tue, 2 Jun 2026 15:04:50 -0700
Subject: [PATCH 2/4] Update build script

---
 build.xml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/build.xml b/build.xml
index dfdf9dc..55671cb 100644
--- a/build.xml
+++ b/build.xml
@@ -25,6 +25,7 @@
 		<delete file="${dir}/package-lock.json" />
 		<delete file="${dir}/phpunit.xml.dist" />
 		<delete file="${dir}/README.md" />
+		<delete file="${dir}/DOCUMENTATION.md" />
 	</target>
 
 	<!--

From 91543207ab6f1a0e3218c6826f07225de2db82d8 Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Thu, 4 Jun 2026 10:07:52 -0700
Subject: [PATCH 3/4] Update Docs

---
 DOCUMENTATION.md | 49 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 39 insertions(+), 10 deletions(-)

diff --git a/DOCUMENTATION.md b/DOCUMENTATION.md
index 546b305..5bbaf56 100644
--- a/DOCUMENTATION.md
+++ b/DOCUMENTATION.md
@@ -571,20 +571,26 @@ Exposes Consent Manager's startup data. This is for internal use; extension inte
 
 For extensions or templates that render iframe-based external media **outside** phpBB's bbcode engine, only output the deferred Consent Manager wrapper when the embedded media category is enabled. Otherwise, keep rendering the normal iframe.
 
-Twig example:
+Let's look at how we would handle the following iframe:
+
+```html
+<iframe src="https://media.example.com/embed/123" width="640" height="360" allowfullscreen></iframe>
+```
+
+### Pattern 1: Twig template example
 
 ```twig
 {% if S_CONSENTMANAGER_MEDIA_ENABLED %}
 	<span data-consent-media-container="1" data-consent-category="media">
 		<span data-consent-media-placeholder="1" data-consent-link="https://media.example.com/watch/123"></span>
-		<span data-consent-media-content="1" hidden="hidden">
-			<iframe
-				data-consent-media-frame="1"
-				data-consent-src="https://media.example.com/embed/123"
-				width="640"
-				height="360"
-				allowfullscreen></iframe>
-		</span>
+		<iframe
+			data-consent-media-content="1"
+			data-consent-media-frame="1"
+			hidden="hidden"
+			data-consent-src="https://media.example.com/embed/123"
+			width="640"
+			height="360"
+			allowfullscreen></iframe>
 	</span>
 {% else %}
 	<iframe
@@ -611,7 +617,30 @@ Use this pattern for:
 
 - extension template files that print iframes directly
 - integrations that embed third-party widgets with raw iframes instead of bbcode
-- custom board markup where iframes were added manually, whether by editing phpBB files directly or through another extension that allows custom HTML/Twig
+- custom markup where iframes were added manually, whether by editing phpBB files directly or through an extension that allows Twig template code injection
+
+### Pattern 2: Manual markup
+
+Use this when the iframe is injected outside phpBB's Twig template system, and you know Consent Manager is installed with the embedded media category enabled. This pattern does not include a fallback because static non-Twig HTML cannot check `S_CONSENTMANAGER_MEDIA_ENABLED`.
+
+```html
+<span data-consent-media-container="1" data-consent-category="media">
+	<span data-consent-media-placeholder="1" data-consent-link="https://media.example.com/watch/123"></span>
+	<iframe
+		data-consent-media-frame="1"
+		data-consent-media-content="1"
+		hidden="hidden"
+		data-consent-src="https://media.example.com/embed/123"
+		width="640"
+		height="360"
+		allowfullscreen></iframe>
+</span>
+```
+
+Use this pattern for:
+
+- ACP/custom-code features that inject raw HTML into pages
+- integrations that output iframe markup after phpBB's bbcode and Twig rendering have already finished
 
 ## Examples of Consent Manager integrations
 

From 257f647a915f963095bcc1fec904b9bd9d4fa126 Mon Sep 17 00:00:00 2001
From: Matt Friedman <maf675@gmail.com>
Date: Thu, 4 Jun 2026 10:39:22 -0700
Subject: [PATCH 4/4] Fix tests

---
 tests/event/listener_test.php | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/event/listener_test.php b/tests/event/listener_test.php
index 8a23bcd..38aebe5 100644
--- a/tests/event/listener_test.php
+++ b/tests/event/listener_test.php
@@ -207,6 +207,13 @@ public function test_inject_frontend_skips_category_blocks_when_frontend_disable
 		$template->expects(self::never())
 			->method('assign_block_vars');
 
-		$this->create_listener($helper, $consent_manager, $template)->inject_frontend();
+		$listener = new class($helper, $this->language, $consent_manager, $template, $this->media_manager) extends \phpbb\consentmanager\event\listener {
+			protected function is_acp_or_installer()
+			{
+				return false;
+			}
+		};
+
+		$listener->inject_frontend();
 	}
 }