Remove unused $universalObjectCratesClasses from ImpossibleCheckTypeHelper

phpstan-bot · claude · phpstan-bot · commit 5636bb6dfe31 · 2026-05-05T08:41:55.000Z
Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/Rules/Comparison/ImpossibleCheckTypeHelper.php b/src/Rules/Comparison/ImpossibleCheckTypeHelper.php
@@ -44,15 +44,10 @@
 final class ImpossibleCheckTypeHelper
 {
 
-	/**
-	 * @param string[] $universalObjectCratesClasses
-	 */
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
 		private TypeSpecifier $typeSpecifier,
 		#[AutowiredParameter]
-		private array $universalObjectCratesClasses,
-		#[AutowiredParameter]
 		private bool $treatPhpDocTypesAsCertain,
 	)
 	{
@@ -417,7 +412,6 @@ public function doNotTreatPhpDocTypesAsCertain(): self
 		return new self(
 			$this->reflectionProvider,
 			$this->typeSpecifier,
-			$this->universalObjectCratesClasses,
 			false,
 		);
 	}
diff --git a/src/Type/Php/TypeSpecifyingFunctionsDynamicReturnTypeExtension.php b/src/Type/Php/TypeSpecifyingFunctionsDynamicReturnTypeExtension.php
@@ -25,15 +25,10 @@ final class TypeSpecifyingFunctionsDynamicReturnTypeExtension implements Dynamic
 
 	private ?ImpossibleCheckTypeHelper $helper = null;
 
-	/**
-	 * @param string[] $universalObjectCratesClasses
-	 */
 	public function __construct(
 		private ReflectionProvider $reflectionProvider,
 		#[AutowiredParameter]
 		private bool $treatPhpDocTypesAsCertain,
-		#[AutowiredParameter]
-		private array $universalObjectCratesClasses,
 	)
 	{
 	}
@@ -76,7 +71,7 @@ public function getTypeFromFunctionCall(
 
 	private function getHelper(): ImpossibleCheckTypeHelper
 	{
-		return $this->helper ??= new ImpossibleCheckTypeHelper($this->reflectionProvider, $this->typeSpecifier, $this->universalObjectCratesClasses, $this->treatPhpDocTypesAsCertain);
+		return $this->helper ??= new ImpossibleCheckTypeHelper($this->reflectionProvider, $this->typeSpecifier, $this->treatPhpDocTypesAsCertain);
 	}
 
 }
diff --git a/tests/PHPStan/Rules/Comparison/BooleanAndConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/BooleanAndConstantConditionRuleTest.php
@@ -23,7 +23,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/BooleanNotConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/BooleanNotConstantConditionRuleTest.php
@@ -23,7 +23,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/BooleanOrConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/BooleanOrConstantConditionRuleTest.php
@@ -24,7 +24,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/DoWhileLoopConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/DoWhileLoopConstantConditionRuleTest.php
@@ -18,7 +18,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->shouldTreatPhpDocTypesAsCertain(),
 				),
 				$this->shouldTreatPhpDocTypesAsCertain(),
diff --git a/tests/PHPStan/Rules/Comparison/ElseIfConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/ElseIfConstantConditionRuleTest.php
@@ -24,7 +24,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/IfConstantConditionRuleTest.php
@@ -21,7 +21,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php
@@ -6,7 +6,6 @@
 use PHPStan\Testing\RuleTestCase;
 use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\RequiresPhp;
-use stdClass;
 use function array_filter;
 use function array_map;
 use function array_values;
@@ -28,7 +27,6 @@ protected function getRule(): Rule
 			new ImpossibleCheckTypeHelper(
 				self::createReflectionProvider(),
 				$this->getTypeSpecifier(),
-				[stdClass::class],
 				$this->treatPhpDocTypesAsCertain,
 			),
 			new PossiblyImpureTipHelper(true),
diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeGenericOverwriteRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeGenericOverwriteRuleTest.php
@@ -17,7 +17,6 @@ public function getRule(): Rule
 			new ImpossibleCheckTypeHelper(
 				self::createReflectionProvider(),
 				$this->getTypeSpecifier(),
-				[],
 				true,
 			),
 			new PossiblyImpureTipHelper(true),
diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleEqualsTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleEqualsTest.php
@@ -17,7 +17,6 @@ public function getRule(): Rule
 			new ImpossibleCheckTypeHelper(
 				self::createReflectionProvider(),
 				$this->getTypeSpecifier(),
-				[],
 				true,
 			),
 			new PossiblyImpureTipHelper(true),
diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleTest.php
@@ -23,7 +23,6 @@ public function getRule(): Rule
 			new ImpossibleCheckTypeHelper(
 				self::createReflectionProvider(),
 				$this->getTypeSpecifier(),
-				[],
 				$this->treatPhpDocTypesAsCertain,
 			),
 			new PossiblyImpureTipHelper(true),
diff --git a/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRuleTest.php b/tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRuleTest.php
@@ -23,7 +23,6 @@ public function getRule(): Rule
 			new ImpossibleCheckTypeHelper(
 				self::createReflectionProvider(),
 				$this->getTypeSpecifier(),
-				[],
 				$this->treatPhpDocTypesAsCertain,
 			),
 			new PossiblyImpureTipHelper(true),
diff --git a/tests/PHPStan/Rules/Comparison/LogicalXorConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/LogicalXorConstantConditionRuleTest.php
@@ -18,7 +18,6 @@ protected function getRule(): TRule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->shouldTreatPhpDocTypesAsCertain(),
 				),
 				$this->shouldTreatPhpDocTypesAsCertain(),
diff --git a/tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php b/tests/PHPStan/Rules/Comparison/MatchExpressionRuleTest.php
@@ -21,7 +21,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/TernaryOperatorConstantConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/TernaryOperatorConstantConditionRuleTest.php
@@ -20,7 +20,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->treatPhpDocTypesAsCertain,
 				),
 				$this->treatPhpDocTypesAsCertain,
diff --git a/tests/PHPStan/Rules/Comparison/WhileLoopAlwaysFalseConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/WhileLoopAlwaysFalseConditionRuleTest.php
@@ -18,7 +18,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->shouldTreatPhpDocTypesAsCertain(),
 				),
 				$this->shouldTreatPhpDocTypesAsCertain(),
diff --git a/tests/PHPStan/Rules/Comparison/WhileLoopAlwaysTrueConditionRuleTest.php b/tests/PHPStan/Rules/Comparison/WhileLoopAlwaysTrueConditionRuleTest.php
@@ -19,7 +19,6 @@ protected function getRule(): Rule
 				new ImpossibleCheckTypeHelper(
 					self::createReflectionProvider(),
 					$this->getTypeSpecifier(),
-					[],
 					$this->shouldTreatPhpDocTypesAsCertain(),
 				),
 				$this->shouldTreatPhpDocTypesAsCertain(),

Original file line number	Diff line number	Diff line change
`@@ -44,15 +44,10 @@`
`44`	`44`	`final class ImpossibleCheckTypeHelper`
`45`	`45`	`{`
`46`	`46`
`47`		`- /**`
`48`		`- * @param string[] $universalObjectCratesClasses`
`49`		`- */`
`50`	`47`	`public function __construct(`
`51`	`48`	`private ReflectionProvider $reflectionProvider,`
`52`	`49`	`private TypeSpecifier $typeSpecifier,`
`53`	`50`	`#[AutowiredParameter]`
`54`		`- private array $universalObjectCratesClasses,`
`55`		`- #[AutowiredParameter]`
`56`	`51`	`private bool $treatPhpDocTypesAsCertain,`
`57`	`52`	`)`
`58`	`53`	`{`
`@@ -417,7 +412,6 @@ public function doNotTreatPhpDocTypesAsCertain(): self`
`417`	`412`	`return new self(`
`418`	`413`	`$this->reflectionProvider,`
`419`	`414`	`$this->typeSpecifier,`
`420`		`- $this->universalObjectCratesClasses,`
`421`	`415`	`false,`
`422`	`416`	`);`
`423`	`417`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,15 +25,10 @@ final class TypeSpecifyingFunctionsDynamicReturnTypeExtension implements Dynamic`
`25`	`25`
`26`	`26`	`private ?ImpossibleCheckTypeHelper $helper = null;`
`27`	`27`
`28`		`- /**`
`29`		`- * @param string[] $universalObjectCratesClasses`
`30`		`- */`
`31`	`28`	`public function __construct(`
`32`	`29`	`private ReflectionProvider $reflectionProvider,`
`33`	`30`	`#[AutowiredParameter]`
`34`	`31`	`private bool $treatPhpDocTypesAsCertain,`
`35`		`- #[AutowiredParameter]`
`36`		`- private array $universalObjectCratesClasses,`
`37`	`32`	`)`
`38`	`33`	`{`
`39`	`34`	`}`
`@@ -76,7 +71,7 @@ public function getTypeFromFunctionCall(`
`76`	`71`
`77`	`72`	`private function getHelper(): ImpossibleCheckTypeHelper`
`78`	`73`	`{`
`79`		`- return $this->helper ??= new ImpossibleCheckTypeHelper($this->reflectionProvider, $this->typeSpecifier, $this->universalObjectCratesClasses, $this->treatPhpDocTypesAsCertain);`
	`74`	`+ return $this->helper ??= new ImpossibleCheckTypeHelper($this->reflectionProvider, $this->typeSpecifier, $this->treatPhpDocTypesAsCertain);`
`80`	`75`	`}`
`81`	`76`
`82`	`77`	`}`