Rename checkPurity parameter to reportMethodPurityOverride for consistency

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: phpstan-bot

conf/services.neon

@@ -98,7 +98,7 @@ services:
 		arguments:
 			reportMaybes: %reportMaybesInMethodSignatures%
 			reportStatic: %reportStaticMethodSignatures%
-			checkPurity: %featureToggles.reportMethodPurityOverride%
+			reportMethodPurityOverride: %featureToggles.reportMethodPurityOverride%
 
 	phpstanDiagnoseExtension:
 		class: PHPStan\Diagnose\PHPStanDiagnoseExtension

src/Rules/Methods/MethodSignatureRule.php

@@ -41,7 +41,7 @@ public function __construct(
 		private ParentMethodHelper $parentMethodHelper,
 		private bool $reportMaybes,
 		private bool $reportStatic,
-		private bool $checkPurity,
+		private bool $reportMethodPurityOverride,
 	)
 	{
 	}
@@ -67,7 +67,7 @@ public function processNode(Node $node, Scope $scope): array
 		$errors = [];
 		$declaringClass = $method->getDeclaringClass();
 		foreach ($this->parentMethodHelper->collectParentMethods($methodName, $method->getDeclaringClass()) as [$parentMethod, $parentMethodDeclaringClass]) {
-			if ($this->checkPurity && $method->isPure()->no() && $parentMethod->isPure()->yes()) {
+			if ($this->reportMethodPurityOverride && $method->isPure()->no() && $parentMethod->isPure()->yes()) {
 				$errors[] = RuleErrorBuilder::message(sprintf(
 					'Impure method %s::%s() overrides pure method %s::%s().',
 					$method->getDeclaringClass()->getDisplayName(),

tests/PHPStan/Rules/Methods/MethodSignatureRuleTest.php

@@ -19,7 +19,7 @@ class MethodSignatureRuleTest extends RuleTestCase
 
 	private bool $reportStatic;
 
-	private bool $checkPurity = false;
+	private bool $reportMethodPurityOverride = false;
 
 	protected function getRule(): Rule
 	{
@@ -29,7 +29,7 @@ protected function getRule(): Rule
 
 		return new OverridingMethodRule(
 			$phpVersion,
-			new MethodSignatureRule(new ParentMethodHelper($phpClassReflectionExtension), $this->reportMaybes, $this->reportStatic, $this->checkPurity),
+			new MethodSignatureRule(new ParentMethodHelper($phpClassReflectionExtension), $this->reportMaybes, $this->reportStatic, $this->reportMethodPurityOverride),
 			true,
 			new MethodParameterComparisonHelper($phpVersion),
 			new MethodVisibilityComparisonHelper(),
@@ -571,7 +571,7 @@ public function testBug14563(): void
 	{
 		$this->reportMaybes = true;
 		$this->reportStatic = true;
-		$this->checkPurity = true;
+		$this->reportMethodPurityOverride = true;
 		$this->analyse([__DIR__ . '/data/bug-14563.php'], [
 			[
 				'Impure method Bug14563\ChildImpureOverridesPure::pure() overrides pure method Bug14563\Foo::pure().',
@@ -617,7 +617,7 @@ public function testBug14563Trait(): void
 	{
 		$this->reportMaybes = true;
 		$this->reportStatic = true;
-		$this->checkPurity = true;
+		$this->reportMethodPurityOverride = true;
 		$this->analyse([__DIR__ . '/data/bug-14563-trait.php'], [
 			[
 				'Impure method Bug14563Trait\ImpureTraitUser::pureTraitMethod() overrides pure method Bug14563Trait\PureTrait::pureTraitMethod().',