Type acceptance tests

Author: ondrejmirtes

tests/PHPStan/Analyser/ReportUnsafeArrayStringKeyCastingDetectTypeAcceptanceTest.php

@@ -29,6 +29,16 @@ public function testRule(): void
 				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\Foo::doBaz() expects array<non-decimal-int-string, stdClass>, non-empty-array<string, stdClass> given.',
 				39,
 			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<string, stdClass>} given.',
+				79,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type string.',
+			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<string, stdClass>} given.',
+				85,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type string.',
+			],
 		]);
 	}
 

tests/PHPStan/Analyser/ReportUnsafeArrayStringKeyCastingPreventTypeAcceptanceTest.php

@@ -37,6 +37,26 @@ public function testRule(): void
 				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\Foo::doBaz() expects array<non-decimal-int-string, stdClass>, non-empty-array<int|non-decimal-int-string, stdClass> given.',
 				39,
 			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doFoo() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<int<min, -1>|int<1, max>|non-decimal-int-string, stdClass>} given.',
+				77,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type int<min, -1>|int<1, max>|non-decimal-int-string.',
+			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<int<min, -1>|int<1, max>|non-decimal-int-string, stdClass>} given.',
+				79,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type int<min, -1>|int<1, max>|non-decimal-int-string.',
+			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doFoo() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<int<min, -1>|int<1, max>|non-decimal-int-string, stdClass>} given.',
+				83,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type int<min, -1>|int<1, max>|non-decimal-int-string.',
+			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<int<min, -1>|int<1, max>|non-decimal-int-string, stdClass>} given.',
+				85,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type int<min, -1>|int<1, max>|non-decimal-int-string.',
+			],
 		]);
 	}
 

tests/PHPStan/Analyser/ReportUnsafeArrayStringKeyCastingUnsafeTypeAcceptanceTest.php

@@ -28,6 +28,16 @@ public function testRule(): void
 				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\Foo::doBaz() expects array<non-decimal-int-string, stdClass>, non-empty-array<string, stdClass> given.',
 				39,
 			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<string, stdClass>} given.',
+				79,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type string.',
+			],
+			[
+				'Parameter #1 $a of method ReportUnsafeArrayStringKeyCastingAccepts\UnsealedArrayShape::doBaz() expects array{stdClass, ...<non-decimal-int-string, stdClass>}, array{stdClass, ...<string, stdClass>} given.',
+				85,
+				'Unsealed array key type non-decimal-int-string does not accept unsealed array key type string.',
+			],
 		]);
 	}
 

tests/PHPStan/Analyser/data/report-unsafe-array-string-key-casting-accepts.php

@@ -40,3 +40,49 @@ public function doTest(string $s): void
 	}
 
 }
+
+class UnsealedArrayShape
+{
+
+	/**
+	 * @param array{stdClass, ...<string, stdClass>} $a
+	 * @return void
+	 */
+	public function doFoo(array $a): void
+	{
+
+	}
+
+	/**
+	 * @param array{stdClass, ...<int|string, stdClass>} $a
+	 * @return void
+	 */
+	public function doBar(array $a): void
+	{
+
+	}
+
+	/**
+	 * @param array{stdClass, ...<non-decimal-int-string, stdClass>} $a
+	 * @return void
+	 */
+	public function doBaz(array $a): void
+	{
+
+	}
+
+	public function doTest(string $s): void
+	{
+		$a = [new stdClass(), $s => new stdClass()];
+		$this->doFoo($a);
+		$this->doBar($a);
+		$this->doBaz($a);
+
+		$b = [new stdClass()];
+		$b[$s] = new stdClass();
+		$this->doFoo($b);
+		$this->doBar($b);
+		$this->doBaz($b);
+	}
+
+}