Skip to content

Verify write-path symlinks before creating run directories #54

Description

@ElbertePlinio

Problem

The run write path (createRunensureDirfs.promises.mkdir(recursive:true)) performs none of the lstat-before-realpath symlink verification the read path does (verifiedRoot/readVerifiedRootFile). A .picklab symlink committed in a target repo could redirect project-local-mode writes at mkdir time.

Pre-existing behavior — predates #34, which actually reduces exposure by making project-local opt-in instead of default. Surfaced by the #34 security review; not a blocker there.

Expected

The write path applies the same root-verification discipline as the read path before creating/writing run directories.

Refs #34

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions