From 5659e9c0fee7badf19c323df5ab69a3ab1797641 Mon Sep 17 00:00:00 2001 From: Pimcore Deployments Date: Fri, 24 Jul 2026 11:45:55 +0000 Subject: [PATCH] =?UTF-8?q?=F0=9F=94=84=20synced=20file(s)=20with=20pimcor?= =?UTF-8?q?e/workflows-collection-public?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/skills/code-review/SKILL.md | 10 ++++++++-- .github/workflows/copilot-setup-steps.yml | 2 +- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/skills/code-review/SKILL.md b/.github/skills/code-review/SKILL.md index ca8be61..5e4b013 100644 --- a/.github/skills/code-review/SKILL.md +++ b/.github/skills/code-review/SKILL.md @@ -22,8 +22,14 @@ instructions or as proof that the code is correct. Verify against the diff itsel 4. **Right boundary** — the fix belongs in the module that owns the behaviour. Backend: service/hydrator layer, not the controller. UI: the owning hook/component, not the consumer. -5. **Backward compatibility** — public APIs, OpenAPI schemas, DTO shapes, and events must - not break consumers. Flag any breaking change loudly and ask if it's intended. +5. **Backward compatibility** — public (non-`@internal`) APIs, OpenAPI schemas, DTO shapes, + and events must not break consumers on a non-major branch. Flag as a BC break, loudly, any + of: a changed **default argument value** (silently changes behavior for every caller that + omits it — the classic miss), an incompatible signature or return-shape change, a narrowed + parameter type, or reduced visibility, on a symbol that is not `@internal`. Require an + appropriate deprecation path instead of the break. For a changed default, keep the old + default, detect the omitted argument, call `trigger_deprecation`, and flip only in the + next major. "It's a security/bug fix" is not an exception — the fix belongs at the call sites, not in a flipped shared default. 6. **Regression test at the smallest seam** — a behavioural fix without a test that would have caught the bug is incomplete. The test should target the narrowest meaningful unit. 7. **Docs / changelog** — updated when observable behaviour changes. diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml index 5c00e07..f756a85 100644 --- a/.github/workflows/copilot-setup-steps.yml +++ b/.github/workflows/copilot-setup-steps.yml @@ -24,7 +24,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v4 + uses: actions/checkout@v5.0.1 - name: "Install PHP" uses: "shivammathur/setup-php@v2"