From 7675101ca2b3691a50385ff66f13c0072c1c40a4 Mon Sep 17 00:00:00 2001
From: kinarob <kinarobin@outlook.com>
Date: Sat, 22 Jun 2019 15:16:11 +0800
Subject: [PATCH] support adding operations after completion or  and perform
 group cancel cancelation

---
 Source/PINOperationGroup.m | 30 +++++++++++++++++++++---------
 1 file changed, 21 insertions(+), 9 deletions(-)

diff --git a/Source/PINOperationGroup.m b/Source/PINOperationGroup.m
index ddd2ed0..3d1965a 100644
--- a/Source/PINOperationGroup.m
+++ b/Source/PINOperationGroup.m
@@ -82,6 +82,7 @@ - (void)start
         dispatch_block_t groupBlock = ^{
           originalOperation();
           dispatch_group_leave(self->_group);
+          [self removeOperationReferenceWithIndex:idx];
         };
         
         id <PINOperationReference> operationReference = [_operationQueue scheduleOperation:groupBlock withPriority:[_operationPriorities[idx] unsignedIntegerValue]];
@@ -94,10 +95,6 @@ - (void)start
           [self runCompletionIfNeeded];
         });
       }
-      
-      _operations = nil;
-      _operationPriorities = nil;
-      _operationReferences = nil;
     }
   [self unlock];
 }
@@ -113,16 +110,30 @@ - (void)cancel
       }
     }
   
-    //TODO just nil out instead? Does it make sense to support adding operations after cancelation?
-    [_groupToOperationReferences removeAllObjects];
-    [_operations removeAllObjects];
-    [_operationPriorities removeAllObjects];
-    [_operationReferences removeAllObjects];
+    //Make sense to support adding operations after completion or cancelation
+    [self locked_removeAllOperations];
     
     _completion = nil;
   [self unlock];
 }
 
+- (void)removeOperationReferenceWithIndex:(NSUInteger)index
+{
+  [self lock];
+    if (index < _operationReferences.count) {
+      [_groupToOperationReferences removeObjectForKey:_operationReferences[index]];
+    }
+  [self unlock];
+}
+
+- (void)locked_removeAllOperations
+{
+  [_groupToOperationReferences removeAllObjects];
+  [_operations removeAllObjects];
+  [_operationPriorities removeAllObjects];
+  [_operationReferences removeAllObjects];
+}
+
 - (id <PINGroupOperationReference>)addOperation:(dispatch_block_t)operation
 {
   return [self addOperation:operation withPriority:PINOperationQueuePriorityDefault];
@@ -167,6 +178,7 @@ - (void)runCompletionIfNeeded
   [self lock];
     completion = _completion;
     _completion = nil;
+    [self locked_removeAllOperations];
   [self unlock];
 
   if (completion) {