add hasProperty, hasDefinedProperty, hasValorizedProperty and PossibleKeys#191
Open
raythurnvoid wants to merge 4 commits into
Open
add hasProperty, hasDefinedProperty, hasValorizedProperty and PossibleKeys#191raythurnvoid wants to merge 4 commits into
raythurnvoid wants to merge 4 commits into
Conversation
piotrwitek
requested changes
Feb 7, 2024
piotrwitek
left a comment
Owner
There was a problem hiding this comment.
Hey @raythurnevoid thanks a lot for your contribution. It looks amazing.
I have a couple of suggestions regarding the naming conventions of this project to keep consistency :)
If you could apply comments I would be more than happy to merge and release :)
Optionally you could put yourself or sources in the jsdocs credits :)
Thank you :)
| }; | ||
| ``` | ||
|
|
||
| ### `hasProperty` |
| } | ||
| ``` | ||
|
|
||
| ### `hasValorizedProperty` |
Owner
There was a problem hiding this comment.
I'm gravitating towadrs hasNonEmptyProperty WDYT?
Comment on lines
+471
to
+488
| ### `PossibleKeys<T>` | ||
|
|
||
| Similar to [`$Keys`](#keyst) or `keyof`, but get keys also from union types | ||
|
|
||
| **Usage:** | ||
|
|
||
| ```ts | ||
| type Props = { name: string; employeeId: string } | { name: string; guestId: string }; | ||
| // Expect: "name" | "employeeId" | "guestId" | ||
| type PropsKeys1 = PossibleKeys<Props>; | ||
| // Expect: "name" | ||
| type PropsKeys2 = $Keys<Props>; | ||
| // Expect: "name" | ||
| type PropsKeys3 = keyof Props; | ||
| ``` | ||
|
|
||
| [⇧ back to top](#table-of-contents) | ||
|
|
Owner
There was a problem hiding this comment.
we already have another proposal for this type called UnionKeys.
I layed out specs there which are not respected here so I propose either:
- update this PR according to specs
- remove this type from this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add 3 new objects related functions and 1 new utility type for union types:
hasPropertyCheck if the object has the property, similar to the
inoperator'key' in objbut unexistent properties are not allowed and it allows intellisenseUsage:
hasDefinedPropertyCheck if the object has the property and it is not
undefinedUsage:
hasValorizedPropertyCheck if the object has the property and it is not
undefinedand notnullUsage:
PossibleKeys<T>Similar to
$Keysorkeyof, but get keys also from union typesUsage:
Related issues:
Checklist
For bugfixes:
For new features:
dts-jest