From 06d482f5a97c888de7aff93439d5e2b88fb3b8d7 Mon Sep 17 00:00:00 2001 From: David Norton Date: Sun, 29 Mar 2026 16:02:55 -0500 Subject: [PATCH] Warn when --sort-by is used that results may not be globally sorted Closes #68 Co-Authored-By: Claude Sonnet 4.6 --- cmd/exec.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/cmd/exec.go b/cmd/exec.go index 307b98e..520fd42 100644 --- a/cmd/exec.go +++ b/cmd/exec.go @@ -125,7 +125,20 @@ func (p *progressBar) finish() { <-p.done } +func hasSortBy(args []string) bool { + for _, arg := range args { + if arg == "--sort-by" || strings.HasPrefix(arg, "--sort-by=") { + return true + } + } + return false +} + func runCommand(subcommand string, extraArgs []string) error { + if hasSortBy(extraArgs) { + fmt.Fprintf(os.Stderr, "Warning: --sort-by sorts within each context independently and may not produce the expected global ordering. See https://github.com/platformersdev/kubectl-x/issues/29\n") + } + contexts, err := getContexts() if err != nil { return fmt.Errorf("failed to get contexts: %w", err)