Skip to content

fix(release): release-please bumps the wrong deno.json — app version stuck at 0.0.0 #10

Description

@amondnet

Problem

release-please-config.json declares an extra-files entry pointing at the root deno.json:

{ "type": "json", "path": "deno.json", "jsonpath": "$.version" }

The root deno.json has no version key. The version actually lives in apps/desktop/deno.json:

{ "name": "@openhwp/desktop", "version": "0.0.0", ... }

Impact

  1. The app version is never bumped. After the v0.1.0 release (chore(main): release 0.1.0 #2, f4735f1), apps/desktop/deno.json still reads "version": "0.0.0" while the repo is tagged v0.1.0. Any installer or binary metadata derived from that manifest carries the wrong version.
  2. Every release rewrites the root deno.json formatting for nothing. release-please still re-serializes the file it was pointed at, expanding inline arrays. In chore(main): release 0.1.0 #2 that produced a +22/-5 diff that was entirely formatting noise (workspace, fmt.include/exclude, lint.include/exclude) with no version line added.

Fix

Point extra-files at the manifest that actually holds the version:

{ "type": "json", "path": "apps/desktop/deno.json", "jsonpath": "$.version" }

plus a one-off bump of apps/desktop/deno.json to 0.1.0 so the next release starts from the correct base.

If per-app version tracking is not wanted, the alternative is to delete the extra-files entry entirely. That also stops the formatting churn, but leaves the app manifest permanently at 0.0.0.

Notes

The root deno.json sits outside the fmt.include scope, so the reformatting does not break deno fmt --check — it is noise, not breakage.

Metadata

Metadata

Assignees

Labels

type:bugSomething isn't working

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions