File tree Expand file tree Collapse file tree
Expand file tree Collapse file tree Original file line number Diff line number Diff line change 4343 if git diff --name-only "$BASE"...HEAD -- stackgl_modules/ | grep -q .; then
4444 echo "stackgl_modules=true" >> "$GITHUB_OUTPUT"
4545 fi
46+ # If any of the directories listed below have changed, we need to re-run the regl-codegen step
4647 # stackgl_modules/ is listed here too because the regl-* shader libs live there;
4748 # changes can alter shader output and require regenerating the precompiled shaders.
4849 if git diff --name-only "$BASE"...HEAD -- src/traces/scattergl/ src/traces/scatterpolargl/ src/traces/splom/ src/traces/parcoords/ src/lib/prepare_regl.js stackgl_modules/ devtools/regl_codegen/ | grep -q .; then
Original file line number Diff line number Diff line change @@ -163,7 +163,7 @@ npm run schema
163163#### Step 9: REGL - Review & commit potential changes to precompiled regl shaders
164164
165165If you are implementing a new feature that involves regl shaders, or if you are
166- making changes that affect the usage of regl shaders, you would need to regenerate the precompiled regl shader code.
166+ making changes that affect the usage of regl shaders, you will need to regenerate the precompiled regl shader code.
167167
168168This is needed because regl performs codegen in runtime which breaks CSP
169169compliance, and so for strict builds we pre-generate regl shader code here.
You can’t perform that action at this time.
0 commit comments