Skip to content

Commit 81ef722

Browse files
camdecosteremilykl
andauthored
Apply suggestions from code review
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
1 parent 4213feb commit 81ef722

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ jobs:
4343
if git diff --name-only "$BASE"...HEAD -- stackgl_modules/ | grep -q .; then
4444
echo "stackgl_modules=true" >> "$GITHUB_OUTPUT"
4545
fi
46+
# If any of the directories listed below have changed, we need to re-run the regl-codegen step
4647
# stackgl_modules/ is listed here too because the regl-* shader libs live there;
4748
# changes can alter shader output and require regenerating the precompiled shaders.
4849
if git diff --name-only "$BASE"...HEAD -- src/traces/scattergl/ src/traces/scatterpolargl/ src/traces/splom/ src/traces/parcoords/ src/lib/prepare_regl.js stackgl_modules/ devtools/regl_codegen/ | grep -q .; then

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ npm run schema
163163
#### Step 9: REGL - Review & commit potential changes to precompiled regl shaders
164164

165165
If you are implementing a new feature that involves regl shaders, or if you are
166-
making changes that affect the usage of regl shaders, you would need to regenerate the precompiled regl shader code.
166+
making changes that affect the usage of regl shaders, you will need to regenerate the precompiled regl shader code.
167167

168168
This is needed because regl performs codegen in runtime which breaks CSP
169169
compliance, and so for strict builds we pre-generate regl shader code here.

0 commit comments

Comments
 (0)