Add desktop chat over WebSocket mirror#150
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Desktop chat client backed by the existing gateway WebSocket, and changes the WebSocket path into a mirror of the shared conversation history instead of a separate output channel.
What changed
workspace/tmp/desktop_chatand rejects WebSocket attachment paths outside that directory.internal_progress_sendimplementations while preferringemit_ws_progresswhen available.Validation
uv run pytest(910 passed, 1 skippedlocally)uv run pytest tests/test_gateway_ws_resolution.pyuv run pytest tests/test_router_tool_budget.py::test_plain_completion_can_stream_for_websocket tests/test_telegram_react_tag_sanitization.py::test_telegram_uses_reply_reaction_fallback_when_immediate_loses_tag tests/test_telegram_react_tag_sanitization.py::test_telegram_infers_reaction_from_short_text_edge_emoji -quv run ruff check src/octopal/gateway/ws.py tests/test_gateway_ws_resolution.pyuv run ruff check src/octopal/runtime/octo/router.py tests/test_telegram_react_tag_sanitization.pyuv run black --check src/octopal/gateway/ws.py tests/test_gateway_ws_resolution.pyuv run black --check src/octopal/runtime/octo/router.py tests/test_telegram_react_tag_sanitization.pynpm run buildfromdesktop/PR Tests #269: success