[codex] Recheck skill state before serving guidance#157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
_run_skill(...)before serving guidanceskill_<id>calls when the skill was disabled or removed after tool registrationWhy
Recent skill management commits added enable/disable support, but dynamic skill handlers still captured the old skill record at registration time. That let a previously exposed
skill_<id>tool keep returning guidance even afterset_skill_enabled(..., enabled=False).Impact
Disabled skills now stay disabled consistently for both generic
use_skilland already-registered dynamicskill_<id>tools.Validation
PYTHONPYCACHEPREFIX=/tmp/pycache python3 -m py_compile src/octopal/tools/skills/management.py tests/test_skill_management.pygit diff --checkNotes
Full
pytestwas not run here because the local systempython3environment does not havepytestinstalled.