From 0da9b65c1f31199f5c820f83b8bd6b7c9568b35b Mon Sep 17 00:00:00 2001 From: Jackson Jarboe <122476654+JacksonJ-KC@users.noreply.github.com> Date: Wed, 17 Dec 2025 16:27:50 -0500 Subject: [PATCH 1/2] add test case --- rct229/utils/std_comparisons_test.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/rct229/utils/std_comparisons_test.py b/rct229/utils/std_comparisons_test.py index 7d87069a54..4988996793 100644 --- a/rct229/utils/std_comparisons_test.py +++ b/rct229/utils/std_comparisons_test.py @@ -13,6 +13,7 @@ ) _M2 = ureg("m2") +_TONS = ureg("tons") def test__std_equal__true_with_units(): @@ -194,6 +195,10 @@ def test__std_equal_with_precision__10_false_without_units(): assert not std_equal_with_precision(155, 150, 10) +def test__std_equal_with_precision__1_true_with_units(): + assert std_equal_with_precision(19.47 * _TONS, 19.452 * _TONS, 1 * _TONS) + + def test__std_conservative_outcome__true_with_units_gt(): assert std_conservative_outcome(1.1 * _M2, 1.05 * _M2, operator.gt) From 58329818a89ba0c3fb0a87980b78f09b53c6d965 Mon Sep 17 00:00:00 2001 From: Jackson Jarboe <122476654+JacksonJ-KC@users.noreply.github.com> Date: Wed, 17 Dec 2025 16:36:00 -0500 Subject: [PATCH 2/2] highlight rounding issue --- rct229/utils/std_comparisons_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rct229/utils/std_comparisons_test.py b/rct229/utils/std_comparisons_test.py index 4988996793..9213d170f1 100644 --- a/rct229/utils/std_comparisons_test.py +++ b/rct229/utils/std_comparisons_test.py @@ -196,7 +196,7 @@ def test__std_equal_with_precision__10_false_without_units(): def test__std_equal_with_precision__1_true_with_units(): - assert std_equal_with_precision(19.47 * _TONS, 19.452 * _TONS, 1 * _TONS) + assert std_equal_with_precision(19.47 * _TONS, 19.52 * _TONS, 1 * _TONS) def test__std_conservative_outcome__true_with_units_gt():