Handle bad response on multipart bundle upload (#814) (#816)

The multipart form path in upload_bundle (used when metadata is provided)
never called handle_bad_response, so a bad HTTP response propagated as a
raw HTTPResponse and caused cryptic downstream failures. Call it for both
upload paths.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: nealrichardson

rsconnect/api.py

@@ -736,7 +736,7 @@ def upload_bundle(
             response = cast(
                 Union[BundleMetadata, HTTPResponse], self.post(f"v1/content/{content_guid}/bundles", body=tarball)
             )
-            response = self._server.handle_bad_response(response)
+        response = self._server.handle_bad_response(response)
         return response
 
     def content_update(self, content_guid: str, updates: Mapping[str, str | None]) -> ContentItemV1:

tests/test_git_metadata.py

@@ -266,3 +266,22 @@ def test_upload_bundle_signature_accepts_metadata(self):
         # Check that upload_bundle has metadata parameter
         sig = signature(RSConnectClient.upload_bundle)
         assert "metadata" in sig.parameters
+
+    def test_upload_bundle_with_metadata_handles_bad_response(self):
+        """A bad response on the multipart (metadata) upload path is surfaced as an
+        RSConnectException rather than a raw HTTPResponse (issue #814)."""
+        import io
+        from unittest.mock import patch
+
+        from rsconnect.api import RSConnectClient, RSConnectException, RSConnectServer
+        from rsconnect.http_support import HTTPResponse
+
+        client = RSConnectClient(RSConnectServer("http://test-server", "api_key"))
+        bad_response = HTTPResponse(
+            "http://test-server/__api__/v1/content/guid/bundles",
+            exception=OSError("connection refused"),
+        )
+        with patch.object(RSConnectClient, "post", return_value=bad_response):
+            with pytest.raises(RSConnectException) as cm:
+                client.upload_bundle("guid", io.BytesIO(b"tarball"), metadata={"source": "git"})
+        assert "connection refused" in str(cm.value)