Skip to content

Commit 9f22fdd

Browse files
authored
remove our workaround for mistune (#794)
1 parent 4acf343 commit 9f22fdd

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

pyproject.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ test = [
3030
"flake8",
3131
"httpretty",
3232
"ipykernel",
33-
"mistune<3.3; python_version=='3.8'", # 3.3+ uses re.Pattern[str], invalid on 3.8
3433
"nbconvert",
3534
"pyright",
3635
"pytest-cov",

tests/test_quickstart.py

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -819,20 +819,13 @@ def fake_get_data(package: str, resource: str):
819819
# ---------------------------------------------------------------------------
820820

821821

822-
# nbconvert pulls mistune>=3.3, which uses re.Pattern[str] and is broken on
823-
# Python 3.8; skip the jupyter-based scaffolds there.
824-
_PY38_NBCONVERT_SKIP = pytest.mark.skipif(
825-
sys.version_info < (3, 9),
826-
reason="nbconvert pulls mistune>=3.3 which is broken on Python 3.8",
827-
)
828-
829822
BOOT_SMOKE_MATRIX = [
830823
pytest.param("streamlit", "http", id="streamlit"),
831824
pytest.param("shiny", "http", id="shiny"),
832825
pytest.param("fastapi", "http", id="fastapi"),
833826
pytest.param("api", "http", id="api"),
834-
pytest.param("voila", "http", id="voila", marks=_PY38_NBCONVERT_SKIP),
835-
pytest.param("notebook", "artifact", id="notebook", marks=_PY38_NBCONVERT_SKIP),
827+
pytest.param("voila", "http", id="voila"),
828+
pytest.param("notebook", "artifact", id="notebook"),
836829
pytest.param("quarto", "artifact", id="quarto"),
837830
]
838831

0 commit comments

Comments
 (0)