Shared storage PV provisioned unconditionally even when load balancing is disabled

[stevenolen]

Summary

The Site controller unconditionally provisions the workbench shared storage PV (both NFS and FSx paths), but the Workbench controller only creates the corresponding PVC when LoadBalancingEnabled == 1. This means a volume is allocated but never claimed when load balancing is disabled.

Current Behavior

Site controller (internal/controller/core/site_controller.go):

• Lines 198-203 (FSx) and 237-242 (NFS): shared storage PV is always provisioned with no conditional check

Workbench controller (internal/controller/core/workbench.go):

• PVC is only created when LoadBalancingEnabled == 1

Other volumes in the Site controller are correctly gated:

• Connect PV: if connectEnabled
• Shared directory PV: if site.Spec.SharedDirectory != ""

Expected Behavior

The shared storage PV should only be provisioned when Workbench load balancing is enabled, consistent with how the PVC is gated and how other conditional volumes are handled.

Impact

• Orphaned PV and wasted storage allocation when load balancing is disabled
• Minor inconsistency, no functional breakage since LoadBalancingEnabled defaults to 1