Skip to content

Commit 1e71853

Browse files
committed
fix(ci): use npm install instead of npm ci
The project doesn't commit package-lock.json, so npm ci fails. Use npm install with --omit=optional to skip FFmpeg optionalDeps.
1 parent 8cf9bde commit 1e71853

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/ci.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ jobs:
3434
node-version: 22
3535

3636
- name: Install dependencies
37-
run: npm ci --omit=optional
37+
run: npm install --omit=optional
3838

3939
- name: Lint C++
4040
run: npm run lint:cpp
@@ -70,7 +70,7 @@ jobs:
7070
node-version: ${{ matrix.node }}
7171

7272
- name: Install dependencies
73-
run: npm ci --omit=optional
73+
run: npm install --omit=optional
7474

7575
- name: Build
7676
run: npm run build
@@ -93,7 +93,7 @@ jobs:
9393
uses: actions/checkout@v4
9494

9595
- name: Install dependencies
96-
run: npm ci --omit=optional
96+
run: npm install --omit=optional
9797

9898
- name: Build
9999
run: npm run build
@@ -120,7 +120,7 @@ jobs:
120120
node-version: ${{ matrix.node }}
121121

122122
- name: Install dependencies
123-
run: npm ci --omit=optional
123+
run: npm install --omit=optional
124124

125125
- name: Build
126126
run: npm run build
@@ -147,7 +147,7 @@ jobs:
147147
node-version: ${{ matrix.node }}
148148

149149
- name: Install dependencies
150-
run: npm ci --omit=optional
150+
run: npm install --omit=optional
151151

152152
- name: Build
153153
run: npm run build

openspec/changes/introduce-ci-workflow/tasks.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
## 9. Validation
7171

7272
- [x] 9.1 Run workflow locally with `act` to validate syntax (if available)
73-
- [ ] 9.2 Push to branch and verify workflow triggers on PR
73+
- [x] 9.2 Push to branch and verify workflow triggers on PR (https://github.com/pproenca/node-webcodecs/pull/10)
7474
- [ ] 9.3 Verify lint job completes in under 2 minutes
7575
- [ ] 9.4 Verify all matrix entries build and test successfully
7676
- [x] 9.5 Test `npm install` locally includes FFmpeg optional dependency

0 commit comments

Comments
 (0)