Improve logging logic#44
Open
Gurjaka wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had cases where we wanted to debug code using the
pretty_logsystem. Our logging levels are defined as:The main issue was that
PRETTY_DEBUGlogs were still emitted inRELEASEbuilds.This PR introduces two commits:
Compile-time debug filtering:
Using the C preprocessor,
PRETTY_DEBUGlogs are only included when the binary is built withDEBUG_MODE. This ensures debug logs are removed from release builds entirely.Time caching optimization:
pretty_log_get_time()now caches the last retrieved time (time_t last) and only updates when the current time (time_t now) changes. This eliminates redundant syscalls, reducing overhead in frequent logging scenarios.