[Bug] Reconnect failure

[stolendata]

Automatic reconnect will not occur if the client is in away status (via autoaway) when a network connectivity loss happens - or, possibly, if the client goes autoaway during a connectivity loss.

I haven't investigated the scenario yet to figure out the necessary order of criteria. I just keep finding Profanity offline for hours every single time I have had network hiccups.

Expected Behavior

Client should keep trying to reconnect regardless of its presence status.

Current Behavior

The client stays disconnected until a keystroke or other action automatically puts it back in online presence, which consequently triggers the reconnect.

Possible Solution

Steps to Reproduce (for bugs)

1. /reconnect 15
2. /autoaway mode away /autoaway time away 5
3. Wait for client to enter away presence
4. Kill network connectivity to server

If you can't reproduce, try switching order of no. 3 and 4.

Environment

Profanity, version 0.15.0
...
Build information:
XMPP library: libstrophe
Desktop notification support: Disabled
OTR support: Enabled (libotr 4.1.1)
PGP support: Enabled (libgpgme 1.24.2)
OMEMO support: Enabled
C plugins: Enabled
Python plugins: Enabled (3.12.11)
GTK icons/clipboard: Disabled
GDK Pixbuf: Disabled

Client runs on OpenBSD. The Jabber server software is Prosody 13.0.2.

[stolendata]

I caught it again. Providing a screenshot in case it helps illustrate things. The reconnect at 10:53 was triggered at first key stroke.

[jubalh]

session_check_autoaway() has an if (conn_status != JABBER_CONNECTED) return;. Probably related?

[jubalh]

@sjaeckel will you have time to do this?
It's one of two remaining issues tagged as bug. Would be cool to have this in 0.18.0.

[jubalh]

@stolendata please test #2192 and also check out /autoping.