From 4347c5865340ebd9b4058c5dbe0673cd193a1a6e Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Tue, 13 Jan 2026 11:07:52 +0000 Subject: [PATCH 1/3] (CAT-2451) Address wrong facter consumption Recently, we realised there was something wrong with the way facter was being consumed in our module acceptance tests. We noticed it seemed to be stuck on the first version of private facter instead of latest. Upon investigation, we found the issue was that we were consuming an unreleased version of public facter instead of the intended one. This commit addressed this issue by pointing to the right repository. --- .github/workflows/module_acceptance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/module_acceptance.yml b/.github/workflows/module_acceptance.yml index 1bfa5be..569b041 100644 --- a/.github/workflows/module_acceptance.yml +++ b/.github/workflows/module_acceptance.yml @@ -80,7 +80,7 @@ jobs: env: BUNDLE_WITHOUT: release_prep PUPPET_GEM_VERSION: '~> 8.9' - FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter#main' # why is this set? + FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter-private#main' TWINGATE_PUBLIC_REPO_KEY: ${{ secrets.TWINGATE_PUBLIC_REPO_KEY }} steps: From fdfb2d776bc312cfd1b9986257b8cecf796c0c91 Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Tue, 13 Jan 2026 11:20:46 +0000 Subject: [PATCH 2/3] point to rubygems instead of github --- .github/workflows/module_acceptance.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/module_acceptance.yml b/.github/workflows/module_acceptance.yml index 569b041..769a338 100644 --- a/.github/workflows/module_acceptance.yml +++ b/.github/workflows/module_acceptance.yml @@ -80,7 +80,7 @@ jobs: env: BUNDLE_WITHOUT: release_prep PUPPET_GEM_VERSION: '~> 8.9' - FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter-private#main' + FACTER_GEM_VERSION: '~> 4.10' TWINGATE_PUBLIC_REPO_KEY: ${{ secrets.TWINGATE_PUBLIC_REPO_KEY }} steps: From 50bd2ce012f53a93c6d73de409cba35aeb1f335a Mon Sep 17 00:00:00 2001 From: Lukas Audzevicius Date: Tue, 13 Jan 2026 11:28:59 +0000 Subject: [PATCH 3/3] fixing unit test workflow as well --- .github/workflows/module_ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/module_ci.yml b/.github/workflows/module_ci.yml index e6a0124..91ff04b 100644 --- a/.github/workflows/module_ci.yml +++ b/.github/workflows/module_ci.yml @@ -86,7 +86,7 @@ jobs: env: BUNDLE_WITHOUT: release_prep PUPPET_GEM_VERSION: ${{ matrix.puppet_version }} - FACTER_GEM_VERSION: 'https://github.com/puppetlabs/facter#main' # why is this set? + FACTER_GEM_VERSION: '~> 4.10' steps: - name: "Checkout"